Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename constraint_group argument to sensitive_attributes #41

Open
AndreFCruz opened this issue Sep 15, 2022 · 0 comments
Open

rename constraint_group argument to sensitive_attributes #41

AndreFCruz opened this issue Sep 15, 2022 · 0 comments
Assignees
@AndreFCruz
Labels
enhancement New feature or request

Comments

@AndreFCruz
Copy link
Contributor

AndreFCruz commented Sep 15, 2022 •
edited

The term constraint_group alludes to constrained optimization, but the main use-case for FairGBM is enhancing fairness and a better kwarg name should probably be chosen.

Suggestions:

  • sensitive_attributes
  • protected_attributes
  • constraint_groups -> note the plural

NOTE
this is a breaking change and will need a corresponding PR in the feedzai-openml-java repository etc.
@AndreFCruz AndreFCruz added the enhancement New feature or request label Sep 15, 2022
@AndreFCruz AndreFCruz self-assigned this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreFCruz AndreFCruz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndreFCruz