Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set custom express query parser as described by the docs #3369

Open
tobiasheldring opened this issue Dec 6, 2023 · 1 comment
Open

Comments

@tobiasheldring
Copy link

The docs describe in this section how to set a custom query parser. It is however not possible, this was reported before and fixed, but unfortunately the fix was reverted as part of this PR.

Any chance this can be fixed so that it is possible to set custom query parser again?

@tobiasheldring
Copy link
Author

Looking closer at the code I realised there is an easy workaround

import feathersExpress from "@feathersjs/express"
import { feathers } from "@feathersjs/feathers"
import express from "express"
import qs from "qs"

const expressApp = express()
expressApp.set("query parser" as any, (str: string) =>
  qs.parse(str, { arrayLimit: 1000 }),
)
const app = feathersExpress(feathers(), expressApp)

Feel free to close this issue, unless you want to use it as basis for updating the docs regarding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant