Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Durability data missing, results in function that always returns None. #493

Open
Miro-Andrin opened this issue Sep 27, 2021 · 0 comments
Open

Comments

@Miro-Andrin
Copy link
Contributor

Description

The method:

impl Item {
   pub fn durability(&self) -> Option<u32> {
        ...
   }
}

Always returns None. This file is generated using 'items.py' using the data from Prismarinejs/minecraft-data. However
the items.json only contains damage values for minecraft 1.14 making our function return None in every case. So currently it does the same as this implementation.

impl Item{
   pub fn durability(&self) -> Option<u32> {
        None
   }
}

Related Issues

If #384 ever pans out, then we would want to add some sanity checks for stuff like this.

@Miro-Andrin Miro-Andrin changed the title Durability data missing results in function that always returns None. Durability data missing, results in function that always returns None. Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant