Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github workflow #480

Open
Miro-Andrin opened this issue Sep 24, 2021 · 2 comments
Open

Improve github workflow #480

Miro-Andrin opened this issue Sep 24, 2021 · 2 comments

Comments

@Miro-Andrin
Copy link
Contributor

Feature Request

Modify the github workflow, such that it checks the server successfully starts when doing cargo run. Recently we had to revert a pull request. It could probably have been prevented if we had this.

Describe the solution you'd like

I don't know how we would check for a successfully start, but we could potentially use grep and search for the first occurrence of
the startup message. Optionally we just run the server for 60 sec.

@Miro-Andrin
Copy link
Contributor Author

@Defman could you add this oo mighty GitHub actions wizard.

@Defman
Copy link
Member

Defman commented Sep 25, 2021

This would require some --dry-run, but I suggest we just start a server in one of the test, which connects to a fake TCP port (tokio testing) throw a few packets at the server and compare against some expected packets.

In the case of Datapacks, the code can be tested as well (fs operations can be tested... might not be ideal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants