Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

テンプレートで用いられている、req.get("id")などの廃止 #338

Closed
uzulla opened this issue Jun 19, 2021 · 1 comment
Closed
Assignees

Comments

@uzulla
Copy link
Collaborator

uzulla commented Jun 19, 2021

<a href="{{ url(req, 'Tags', 'delete', {id: req.get('id'), back_url: req.get('back_url'), sig: sig }) }}" class="btn_contents touch" onclick="return confirm('{{ _('Are you sure you want to delete?') }}');"><i class="delete_icon btn_icon"></i>{{ _('Delete') }}</a>

など、一部パラメタより値を取得している箇所があるが、これらはセキュリティ的に正しくないので廃止する(モデルなどから引けた値をもちいるように修正する)

また、back_url系については、オープンリダイレクタに近い悪用ができる可能性がある。廃止か、緩和の対策を行う(調査し、別ISSUEにするかもしれません)。

uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
uzulla added a commit to uzulla/fc2blog that referenced this issue Aug 8, 2021
fc2dev added a commit that referenced this issue Aug 12, 2021
…ender-html

テンプレートで用いられている、req.get("id")などの廃止 #338
@uzulla
Copy link
Collaborator Author

uzulla commented Aug 12, 2021

マージいただきましたので、クローズいたします。

残は別ISSUE にて行います。 #357

@uzulla uzulla closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant