Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless code #997

Merged
merged 3 commits into from
Dec 13, 2024
Merged

refactor: remove useless code #997

merged 3 commits into from
Dec 13, 2024

Conversation

favonia
Copy link
Owner

@favonia favonia commented Dec 11, 2024

This is part of the fix for #985.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.58%. Comparing base (6f486e1) to head (04c5e68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/protocol/local_auto.go 75.00% 1 Missing ⚠️
internal/provider/protocol/local_iface.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   94.74%   94.58%   -0.16%     
==========================================
  Files          64       62       -2     
  Lines        3465     3364     -101     
==========================================
- Hits         3283     3182     -101     
  Misses        170      170              
  Partials       12       12              
Flag Coverage Δ
unittests 94.58% <95.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia merged commit e761902 into main Dec 13, 2024
9 of 10 checks passed
@favonia favonia deleted the remove-switches branch December 13, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant