Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the README structure #983

Open
NotaInutilis opened this issue Nov 7, 2024 · 5 comments
Open

Improve the README structure #983

NotaInutilis opened this issue Nov 7, 2024 · 5 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@NotaInutilis
Copy link

Hi! I've got an issue with passing the cloudflare API token via a secret on docker compose file. It works when pasting it as an environment variable but outputs an error 😞 Failed to check the existence of a zone named DOMAIN: Invalid request headers (6003) when using a secret. I first asked for help on the formatting of my compose file, but it doesn't seem that there is any issue with it so instead of bashing my head on my keyboard, I'm asking for some help here.

services:
  cloudflare-ddns:
    container_name: cloudflare-ddns
    image: favonia/cloudflare-ddns
    restart: always
    user: ${USER}
    read_only: true
    cap_drop: [all]
    security_opt: [no-new-privileges:true]
    environment:
      - CLOUDFLARE_API_TOKEN=/run/secrets/CLOUDFLARE_API_TOKEN
      - DOMAINS=DOMAIN
      - PROXIED=false
    secrets:
      - CLOUDFLARE_API_TOKEN

secrets:
  CLOUDFLARE_API_TOKEN:
    file: ./secrets/CLOUDFLARE_API_TOKEN.txt
@favonia
Copy link
Owner

favonia commented Nov 7, 2024

Hi! Thanks for opening the issue. The environment variable name for secrets should be CLOUDFLARE_API_TOKEN_FILE instead of CLOUDFLARE_API_TOKEN. Do you think there's something we can change in README to clarify this?

@NotaInutilis
Copy link
Author

NotaInutilis commented Nov 7, 2024

Aaah! It was thar simple, thank you!

I think there are several things that ca be done with the readme.

  1. While I understand why you chose to expand each section (this readme is LONG), it disables search with ctrl+f in the folded sections. I also believe thar just browsing the full extended page, that info would have caught my eye. Tables are easy to recognize and are always used to give configuration info in readmes.
  2. The Compose File section and the All Settings are separated by two other sections (Building and Running, FAQ). I think grouping all the relevant information together would make more sense. I was searching for info around the compose file, not further away in the document.
  3. Adding some keywords like "txt file" and "secrets file" around the API token section of the compose file so that the user knows there are other options they can look for.

I'd say the same for the Proxied option: it looks like a simple binary choice when the more useful info is also hidden.

@favonia favonia added this to the next milestone Nov 7, 2024
@favonia favonia added the documentation Improvements or additions to documentation label Nov 7, 2024
@favonia favonia changed the title Using docker compose secrets for the API does not work Document all settings better Nov 7, 2024
@favonia
Copy link
Owner

favonia commented Nov 8, 2024

@NotaInutilis You are not the only one tripping over the expandable descriptions. I now think I should remove all of the folding.

@favonia favonia changed the title Document all settings better Improve the README structure Nov 8, 2024
@samumakinen
Copy link

I have no issues searching (ctrl+f) the README on Google Chrome (latest) on M2 MacBook. The folds open accordingly when going trough the search results.

I think it could be beneficial to link to the Docker Compose documentation on how to use secrets in general: https://docs.docker.com/compose/how-tos/use-secrets/

@favonia
Copy link
Owner

favonia commented Dec 27, 2024

@samumakinen Thanks for the suggestion.

After further investigation, I now see that Chrome-based browsers will expand the folds automatically but Firefox and Safari will not. 🤔

Let's open another ticket for me to track the documentation of secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants