Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mismatched proxy settings be updated? #964

Open
planet4 opened this issue Oct 4, 2024 · 10 comments
Open

Should mismatched proxy settings be updated? #964

planet4 opened this issue Oct 4, 2024 · 10 comments
Labels
bug Something isn't working as expected logging Related to what the tool outputs to the end user
Milestone

Comments

@planet4
Copy link

planet4 commented Oct 4, 2024

Thanks for sharing this. Just set this up and it seems to be working fine. However I wanted to try if it is able to change in Cloudflare so I changed one domain to proxied, dns only. I restarted the container but in the logs it tells me "Unproxied domains: (none)". Should it be able to change the setting in CF and enable it to proxied?

@favonia
Copy link
Owner

favonia commented Oct 4, 2024

@planet4 Thanks. By design, it will preserve all manual editing except for IP addresses. You manually edited the proxy settings, and the updater assumes that you intentionally did so. May I know the use case where you actually want the updater to overwrite the proxy settings (not just for testing purposes)? The only reason I didn't implement the updater that way is because I didn't find a use case. Perhaps you have one in your mind?

On the other hand, you should have received a reminder like this:

💡 The updater will not overwrite proxy statuses, TTLs, or record comments; you can change them in your Cloudflare dashboard at https://dash.cloudflare.com

I wonder if you have seen it? If not, there's a bug to fix. I'm also open to wording suggestions.

@planet4
Copy link
Author

planet4 commented Oct 4, 2024

Thanks. Just wanted to trigger something so I knew it works. My ip changes about once per year and when it happens I most likely have forgot I set this up. But seems to be working as designed. Do not think i noticed that. I made a screenshot after I did the change. I wanted to include this container in a post I do at my techblog. www.planet4.se
log1

@favonia favonia added the bug Something isn't working as expected label Oct 4, 2024
@favonia favonia changed the title Proxy change No warnings for mismatched proxy settings Oct 4, 2024
@favonia
Copy link
Owner

favonia commented Oct 4, 2024

@planet4 You should definitely get a reminder/warning about mismatched configurations even if the IP addresses were up to date. This looks like a bug, then. And thanks for writing a blog post for this tool.

@favonia favonia added the logging Related to what the tool outputs to the end user label Oct 4, 2024
@favonia
Copy link
Owner

favonia commented Oct 4, 2024

@planet4

  1. Would you be 100% satisfied if the updater shows that the proxy setting differs (but still doesn't change it)?
  2. I see that you wish to have a "testing" mode. I don't have a good design idea for that. May I ask why you didn't change the IP and start the updater?

@planet4
Copy link
Author

planet4 commented Oct 4, 2024

  1. That would be nice.
  2. I just wanted to make sure that the token was correct and it was connected to my cloudflare. But i am happy as it is. Dont think i can change my wan ip as it is dhcp.

Great work. Will use this now with swag and immich. Way more better then my buggy setting in my router.

Greetings from Sweden!

@favonia favonia added this to the 1.15.1 milestone Oct 4, 2024
@favonia
Copy link
Owner

favonia commented Oct 4, 2024

@planet4 BTW, you can set up HEALTHCHECKS or UPTIMEKUMA if you wish to monitor the status of the updater.

@favonia
Copy link
Owner

favonia commented Oct 5, 2024

@planet4 I found the bug but opened another issue #967 so that you will not get lots of notifications from this issue. Let me know if those monitors help---they should address your concerns about not knowing something is broken. If you are satisfied, we can also just close this issue for now.

@favonia favonia changed the title No warnings for mismatched proxy settings Should mismatched proxy settings be updated? Oct 5, 2024
@favonia favonia modified the milestones: 1.15.1, 1.16.0 Oct 5, 2024
@favonia
Copy link
Owner

favonia commented Oct 7, 2024

@planet4 BTW, I checked your blog out of curiosity. You do not need "Account – Account Filter Lists" unless you want to update WAF lists as well. (It seems you are only updating DNS records.) I will check the documentation to see whether any part is confusing, and your feedback will be highly appreciated. Again, thank you for the wrote-up!

@favonia
Copy link
Owner

favonia commented Oct 7, 2024

@planet4 OMG, I found a serious typo in the current README 🤦 sorry about it.

@planet4
Copy link
Author

planet4 commented Oct 7, 2024

Ok, Thanks. My post are kind of in work right now and I might change them. Trying to get everything up and running. Thanks for reading. Mostly geek stuff there and I am no expert what so ever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected logging Related to what the tool outputs to the end user
Projects
None yet
Development

No branches or pull requests

2 participants