-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should mismatched proxy settings be updated? #964
Comments
@planet4 Thanks. By design, it will preserve all manual editing except for IP addresses. You manually edited the proxy settings, and the updater assumes that you intentionally did so. May I know the use case where you actually want the updater to overwrite the proxy settings (not just for testing purposes)? The only reason I didn't implement the updater that way is because I didn't find a use case. Perhaps you have one in your mind? On the other hand, you should have received a reminder like this:
I wonder if you have seen it? If not, there's a bug to fix. I'm also open to wording suggestions. |
Thanks. Just wanted to trigger something so I knew it works. My ip changes about once per year and when it happens I most likely have forgot I set this up. But seems to be working as designed. Do not think i noticed that. I made a screenshot after I did the change. I wanted to include this container in a post I do at my techblog. www.planet4.se |
@planet4 You should definitely get a reminder/warning about mismatched configurations even if the IP addresses were up to date. This looks like a bug, then. And thanks for writing a blog post for this tool. |
|
Great work. Will use this now with swag and immich. Way more better then my buggy setting in my router. Greetings from Sweden! |
@planet4 BTW, you can set up |
@planet4 BTW, I checked your blog out of curiosity. You do not need "Account – Account Filter Lists" unless you want to update WAF lists as well. (It seems you are only updating DNS records.) I will check the documentation to see whether any part is confusing, and your feedback will be highly appreciated. Again, thank you for the wrote-up! |
@planet4 OMG, I found a serious typo in the current README 🤦 sorry about it. |
Ok, Thanks. My post are kind of in work right now and I might change them. Trying to get everything up and running. Thanks for reading. Mostly geek stuff there and I am no expert what so ever. |
Thanks for sharing this. Just set this up and it seems to be working fine. However I wanted to try if it is able to change in Cloudflare so I changed one domain to proxied, dns only. I restarted the container but in the logs it tells me "Unproxied domains: (none)". Should it be able to change the setting in CF and enable it to proxied?
The text was updated successfully, but these errors were encountered: