-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print a warning when running skunk
without a coverage/.resultset.json
#25
Comments
If the result without |
ping @etagwerker |
@bronzdoc I don't think we should make it a requirement, I think it should output a noticeable warning. We have to assume that sometimes a project has no test suite, so they won't have code coverage data, but as they add coverage to their codebase, they might want to see the evolution of their stink score average (related to #5) |
@etagwerker @bronzdoc Maybe there should also be a note in the documentation about having to change the path within the file? |
@FionaDL I think that is an issue in I think it would be useful if |
In the README.md:
Running
skunk
without that file is kind of pointless. The whole idea of the "StinkScore" is to combine RubyCritic's cost with SimpleCov's lack of coverage, in order to get a realistic "StinkScore"So we should make sure the user understands that the scores that they're getting is not that useful.
The text was updated successfully, but these errors were encountered: