-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the terminal color output API #159
Labels
Comments
Is it still pending ? |
@Ishaan28malik, @davesnx has completed the first part. The second part clearScreen is still pending. I.e. if it works on Windows we can safely close it, if it doesn't - the fix would be much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Fastpack was started a while ago before Pastel was introduced. Because of this we came up with a limited implementation of the colored output. See FastpackUtil/Terminal.re, specifically
print_with_color
function.It would be great to get rid of this function in favour of the
Pastel
. An example of thePastel
usage in the Fastpack codebase can be seen in Fastpack/Commands.re.The related issue is the clearScreen function which is known to work on MacOS/Linux terminals, but I totally don't know if it works on Windows. So, it'd be useful to test and fix it to be truly cross-platform.
The text was updated successfully, but these errors were encountered: