Skip to content
This repository has been archived by the owner on Jul 8, 2023. It is now read-only.

Switch hosting provider #315

Open
2 tasks done
luisorbaiceta opened this issue Dec 20, 2021 · 19 comments
Open
2 tasks done

Switch hosting provider #315

luisorbaiceta opened this issue Dec 20, 2021 · 19 comments
Labels
semver-minor Issue or PR that should land as semver minor

Comments

@luisorbaiceta
Copy link
Member

luisorbaiceta commented Dec 20, 2021

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the feature has not already been requested

🚀 Feature Proposal

There is already an open issue that suggest the change to Netlify #84, But I think any provider that has deployment previews and redirections should be fine.

Any good personal experience and recommendation with a hosting provider that meets the motivation of the issue will be very valuable!

Motivation

PR previews (#153 )
Redirections and rewrites (#312 )

@luisorbaiceta
Copy link
Member Author

@sinchang, in your experience with Netlify, do you think it could solve #312?

@luisorbaiceta luisorbaiceta added semver-minor Issue or PR that should land as semver minor help wanted Help the community by contributing to this issue labels Dec 20, 2021
@mcollina
Copy link
Member

I think we can switch to Netlify given (https://www.netlify.com/legal/open-source-policy) or Vercel (https://vercel.com/support/articles/can-vercel-sponsor-my-open-source-project).

Whatever you chose - I have contacts on both providers.

@jsumners
Copy link
Member

Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into main.

@mcollina
Copy link
Member

@luisorbaiceta if you include a badge https://www.netlify.com/press/#badges in the footer, I can request an OSS account from Netlify.

@luisorbaiceta
Copy link
Member Author

Really want to see this happen. It's very frustrating not being able to see how changes to docs in the main repo will affect the site without first merging into main.

I'm afraid this is a consequence of the current build process and has nothing to do with the provider. A good solution would be to always work on the same branch the docs changes (wip/docs) and targeting that specific branch in the build process (like we do with master branch). We can leave that part hidden for the final user and only make it available by route access

@jsumners
Copy link
Member

I do not wish to complicate the core repo contribution workflow. The website build should be able to accommodate the normal PR process.

@mcollina
Copy link
Member

@luisorbaiceta it should be possible by triggering a rebuild using the API.

@luisorbaiceta
Copy link
Member Author

If changes have not been merged to master, there is no way to preview them without knowing the name of the branch those changes have been made in beforehand. See here

@luisorbaiceta
Copy link
Member Author

@luisorbaiceta if you include a badge https://www.netlify.com/press/#badges in the footer, I can request an OSS account from Netlify.

Should we choose Netlify then?

@mcollina
Copy link
Member

I would go ahead with Netlify unless somebody has a strong preference for something else. I don't know what would entail to pick Netlify vs something else (or roll our own). I'm just working to create a sponsored account for Fastify.

Do anyone have an objection in picking Netlify?

@luisorbaiceta
Copy link
Member Author

Great! Let me know when credentials are ready so I can start a PR to work on the new workflow

@mcollina
Copy link
Member

I'd need the badge to be there to do that.

@luisorbaiceta
Copy link
Member Author

Should we wait a reasonable time then to see if anyone has any objections with Netlify? If not, I have time to add it now

@mcollina
Copy link
Member

Open a PR, let's wait a day or two to land it.

@jsumners
Copy link
Member

No objections here.

@mcollina
Copy link
Member

I have requested an OSS account from Netlify

@mcollina
Copy link
Member

@luisorbaiceta I have invited you to Netlify

@luisorbaiceta
Copy link
Member Author

Great! We can now trigger deploys by connecting the account to the repo, or by setting up a workflow from github actions. I'm fine with both approaches

@mcollina
Copy link
Member

As you prefer, you should have enough permissions for both - in case let me know.

@luisorbaiceta luisorbaiceta removed the help wanted Help the community by contributing to this issue label Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver-minor Issue or PR that should land as semver minor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants