Fix: Proxy should always return factory wrapped version of app #46
Conversation
| @@ -743,3 +744,19 @@ test('should restart an app before listening', async (t) => { | |||
| await app.close() | |||
| t.ok(!app.server.listening) | |||
| }) | |||
|
|
|||
| test('should always proxy to the factory wrapped version of app', async (t) => { | |||
| async function userProvidedFactory () { | |||
There was a problem hiding this comment.
| async function userProvidedFactory () { | |
| async function userProvidedFactory (fastify) { |
You should pass a fastify factory param instance here.
There was a problem hiding this comment.
Hmm, if you pass the fastify factory as a param (see previous message), your test works on the current version. Not sure that I understand your point. Can you point me to where do you think you receive an app object instead of a proxy wrapper?
There was a problem hiding this comment.
@ivan-tymoshenko Hi Ivan, actually, you're correct, while the proxy is set to const app = fastify({ ...newOpts, serverFactory }) in one place, and newApp = await factory(createApplication, opts, restartOptions) in another, because the proxy contains a reference to the latest copy of the object and the object is being mutated, they are the same.
Our codebase was missing the fastify factory as a param.
Before this change, when the server was first booted, the proxy, which is returned from
restartablewas pointing to a copy of app that's returned fromfastify({ ...newOpts, serverFactory }), but fromawait factory(createApplication, opts, restartOptions)(with the user provided factory wrapper) after restarts.On first boot
appis a reference to what was returned from thefastifywrapper:restartable/index.js
Line 92 in 0b02b0d
restartable/index.js
Line 95 in 0b02b0d
On reboot
newAppis a reference to the output of the usersfactorywrapper:restartable/index.js
Line 27 in 0b02b0d
restartable/index.js
Line 50 in 0b02b0d
It was not possible to access the copy of app wrapped by
factory, unless the server was restarted immediately after fist boot.With this proposed change, the proxy always points to the latest copy of the app wrapped by the users factory.
Fixes #45
Checklist
npm run testandnpm run benchmarkand the Code of conduct