fix: config type in RouteShorthandOptions
#5355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Mar 19, 2024
BrianValente
changed the title
config type in RouteShorthandOptionsconfig type in RouteShorthandOptions
BrianValente
force-pushed
the
bugfix/custom-context-config-types
branch
from
28f8fec
to
dbfed76
Compare
|
@mcollina Sorry, but I couldn't find a way to test this. I'm not familiar with tsd, and the kind of test needed here is complex because it should encapsulate a type declaration just for the test. |
|
@mcollina can you merge it without the tests? I'm relying on patching the library to continue using it. Thanks 🙏 |
|
Arguably no, I can't. The cost of not including tests is so high long term that "you shall not pass" as Gandalf have said. |
BrianValente
force-pushed
the
bugfix/custom-context-config-types
branch
from
c564d55
to
f673385
Compare
|
You're right! The test is ready, it was a fun challenge! If there's something to improve let me know @mcollina |
gurgunday
approved these changes
May 14, 2024
BrianValente
force-pushed
the
bugfix/custom-context-config-types
branch
from
f673385
to
4af194a
Compare
|
Lint fixed, sorry! |
BrianValente
force-pushed
the
bugfix/custom-context-config-types
branch
from
4af194a
to
ec19336
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR fixes #5322.
Checklist
npm run testandnpm run benchmarkand the Code of conduct