-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance code re-usability #208
Comments
I would actually prefer to have a PR that added support for this. |
^ same, but, we could switch to |
Using Symbol.for would make them part of the public API anyway. I don't think it's a good idea as we would have to support many more use cases than what we are currently testing. |
Ok. Let me know and I will make a PR. |
I would actually prefer a PR that adds support for whatever use case you think it's missing rather than exposing internals. |
Prerequisites
🚀 Feature Proposal
It seems that it could not be possible to manage the upgrade event in custom way, without re-writing the entire logic.
The cause seems to be the Symbols used to store headers and socketRef into the
rawReq
object (kWs, kWsHead
)Motivation
Code re-usability.
In my case I have to add custom headers on HTTP Upgrade response #204 (
ws
library under the hood, supports it).Example
Replace Symbol usage with simple string keys or expose some properties to manage the key name attribute.
The text was updated successfully, but these errors were encountered: