-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing vary header for preCompressed files #230
Comments
Would you like to send a Pull Request to address this issue? Remember to add unit tests. |
Should be possible. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still needs doing. |
Probably connected with #300 |
(Obvious) Note: The header is present when static is combined with compress Note 2: accept-encoding is used more than content-encoding as Vary header |
Prerequisites
Fastify version
3.19.0
Plugin version
4.2.0
Node.js version
14.x
Operating system
macOS
Operating system version (i.e. 20.04, 11.3, 10)
11.15.1
Description
The
Vary
Header is not included when servingpreCompressed
assets. This can cause issues with caches serving the incorrect version of pages to browsers.Steps to Reproduce
Serve
preCompressed
assets and check the header response in devtools and you'll see novary: content-encoding
header present.Expected Behavior
I'd expect the
vary: content-encoding
header to be served with all assets. This applies whether or not they werepreCompressed
and whether or not the compressed version is served. The MDN article forvary
also notes some other times it should be included, like with 304 responses.related
#158
The text was updated successfully, but these errors were encountered: