Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameters for custom glob patterns and glob options... #375

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yaneony
Copy link

@yaneony yaneony commented Apr 19, 2023

Added parameters for custom glob patterns and glob options, while also preserving backward compatibility with the serveDotFiles option provided by the plugin. As of #178

Checklist

…o preserving backward compatibility with the serveDotFiles option provided by the plugin.
@Fdawgs Fdawgs linked an issue Apr 19, 2023 that may be closed by this pull request
@yaneony
Copy link
Author

yaneony commented Apr 19, 2023

Test do fail because of previous commits. Even freshly cloned repository fail. Who gonna fix that?

@yaneony yaneony mentioned this pull request Apr 19, 2023
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Frazer Smith <[email protected]>
@Uzlopak
Copy link
Contributor

Uzlopak commented May 12, 2023

Well, without unit tests the CI CD Pipeline will fail, because we expect 100% test coverage.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@mcollina
Copy link
Member

A test is still missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wildcard glob support
4 participants