Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fastify instance to app #9

Closed
Eomm opened this issue Jul 10, 2021 · 6 comments · Fixed by #10
Closed

Rename fastify instance to app #9

Eomm opened this issue Jul 10, 2021 · 6 comments · Fixed by #10
Labels
good first issue Good for newcomers

Comments

@Eomm
Copy link
Member

Eomm commented Jul 10, 2021

🚀 Feature Proposal

As followup
fastify/website#259

Motivation

Better naming convention
@Eomm Eomm added the good first issue Good for newcomers label Jul 10, 2021
@hionnode
Copy link

Can I take up this issue...

@zekth
Copy link
Member

zekth commented Jul 15, 2021

Can I take up this issue...

Go for it

@hionnode
Copy link

Just a doubt, should I fork the repo, or push a feature branch

@climba03003
Copy link
Member

Just a doubt, should I fork the repo, or push a feature branch

Fork it and make a branch on your fork
You cannot push a feature branch here without permission.

@dancastillo
Copy link
Member

@Eomm is this still an issue? I see instance being used on fastify docs here

@Eomm
Copy link
Member Author

Eomm commented Jan 21, 2023

@Eomm is this still an issue? I see instance being used on fastify docs here

I was thing about from:

fastify.addSchema()

to:

app.addSchema()

But there are many things that are not mapped yet. I use a lot this snippet repo ffhello saves me a lot to help people debug little things

@Eomm Eomm reopened this Jan 21, 2023
@Eomm Eomm linked a pull request Jan 22, 2023 that will close this issue
feat: renamed fastify instance to app closes #9 #10
Merged
2 tasks
@Eomm Eomm closed this as completed in #10 Mar 2, 2023
Eomm pushed a commit that referenced this issue Mar 2, 2023
@dancastillo
feat: renamed fastify instance to app closes #9 (#10)
afaa048 
Signed-off-by: dan.castillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: renamed fastify instance to app closes #9
6 participants
@mcollina @zekth @Eomm @dancastillo @climba03003 @hionnode