-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature?: ignored characters `'_ / allowing prefixs 0x and 0b etc... #124
Comments
@Andersama We want the However, we also have the Support for other data types and formats is certainly welcome. Please consider providing a pull request, or many pull requests. |
It looks like parse_number_string is the underlying function that from_char_advanced is using. Were you expecting the drop in to handle hex floats? Currently it seems like it doesn't, and it seems like I'm about to add a fairly large if / else block otherwise with an extra flag integer to parse_options. Pretty sure that'll be a bit of a performance hit. |
We have decent benchmarks so we can assess performance issues. I would not necessarily be overly concerned at first. |
This isn't a performance related feature, but I've found it odd that the charconv spec goes out of its way to avoid parsing what would otherwise be necessary to handle c++'s own floating point literals. What would you think about having some additional utility from_chars like functions to handle those formats?
Ages ago I modified microsoft's charconv to do this for myself, but it broke at some point because headers changed and some utility functions went missing. The core idea is roughly this:
Not used your library, but it seems like hex formatted floats have the enum for the format but aren't supported? Could also be the opportunity to add that in.
The text was updated successfully, but these errors were encountered: