M4 PRO: CPU Frequency

[PierpaoloPernici]

I tried compiling latest (11/11) dev version and my new MBP 14 (Mac16,8) shows:
CPU: Apple M4 Pro (14) @ 0.00 GHz

Should I use some specific parameter to show the real frq ?

thanks

[CarterLi]

It means that the CPU frequency detection code no longer works for M4.

Please paste the result of fastfetch -c all.jsonc --format json for investigation

[PierpaoloPernici]

https://gist.github.com/PierpaoloPernici/229c5e7136cf71a1f040561d5054671a

CPU related:

[{
    "type": "CPU",
    "result": {
      "cpu": "Apple M4 Pro",
      "vendor": "Apple",
      "cores": {
        "physical": 14,
        "logical": 14,
        "online": 14
      },
      "frequency": {
        "base": 0,
        "max": 4
      },
      "coreTypes": [
        {
          "count": 10,
          "freq": 2
        },
        {
          "count": 4,
          "freq": 1
        }
      ],
      "temperature": null
    }
  },
  {
    "type": "CPUCache",
    "result": {
      "l1": [
        {
          "size": 196608,
          "num": 10,
          "lineSize": 0,
          "type": "instruction"
        },
        {
          "size": 131072,
          "num": 10,
          "lineSize": 0,
          "type": "data"
        },
        {
          "size": 131072,
          "num": 4,
          "lineSize": 0,
          "type": "instruction"
        },
        {
          "size": 65536,
          "num": 4,
          "lineSize": 0,
          "type": "data"
        }
      ],
      "l2": [
        {
          "size": 16777216,
          "num": 2,
          "lineSize": 0,
          "type": "unified"
        },
        {
          "size": 4194304,
          "num": 1,
          "lineSize": 0,
          "type": "unified"
        }
      ]
    }
  },
  {
    "type": "CPUUsage",
    "result": [
      50.0,
      36.84210526315789,
      30.0,
      25.0,
      0.0,
      0.0,
      0.0,
      0.0,
      0.0,
      14.285714285714285,
      10.0,
      10.0,
      5.0,
      4.761904761904762
    ]
  },]

[CarterLi]

Can you try this patch?

diff --git a/src/detection/cpu/cpu_apple.c b/src/detection/cpu/cpu_apple.c
index 3c5f4594..bc51136b 100644
--- a/src/detection/cpu/cpu_apple.c
+++ b/src/detection/cpu/cpu_apple.c
@@ -55,8 +55,12 @@ static const char* detectFrequency(FFCPUResult* cpu)
 
     uint32_t* pStart = (uint32_t*) CFDataGetBytePtr(freqProperty);
     uint32_t pMax = *pStart;
+    printf("%u: %u\n", 0, pMax);
     for (CFIndex i = 2; i < propLength / (CFIndex) sizeof(uint32_t) && pStart[i] > 0; i += 2 /* skip voltage */)
+    {
+        printf("%u: %u\n", i, pStart[i]);
         pMax = pMax > pStart[i] ? pMax : pStart[i];
+    }
 
     if (pMax > 0)
         cpu->frequencyMax = pMax / 1000 / 1000;

fastfetch -s cpu --format json

[PierpaoloPernici]

it looks promising:

0: 1260000
2: 1512000
4: 1800000
6: 2088000
8: 2352000
10: 2616000
12: 2868000
14: 3096000
16: 3300000
18: 3468000
20: 3624000
22: 3756000
24: 3852000
26: 3924000
28: 3996000
30: 4044000
32: 4104000
34: 4416000
36: 4512000
[
  {
    "type": "CPU",
    "result": {
      "cpu": "Apple M4 Pro",
      "vendor": "Apple",
      "cores": {
        "physical": 14,
        "logical": 14,
        "online": 14
      },
      "frequency": {
        "base": 0,
        "max": 4
      },
      "coreTypes": [],
      "temperature": null
    }
  }
]

[CarterLi]

Seems that Apple changed the unit reported by IO service. Your M4 Pro reports kHz while my M1 Pro reports Hz.

Strangely they didn't change the GPU side.

[CarterLi]

Please test if 644458b fix your issue.

In addition, e618303 may fix the CFStringGetCString() failed error. You may try fastfetch -s media:player when playing a song

[PierpaoloPernici]

Both commits work well!

[PierpaoloPernici]

thanks again!