Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How to change the licence from Apache-2.0 to GPL-3.0-only ? #1380

Open
Martin15135215 opened this issue Oct 29, 2023 · 1 comment

Comments

@Martin15135215
Copy link

When I used the command nbdev_new it created a settings.ini with license = apache2., How can I change it to GPL-3.0-only ?

And why is the SPDX short identifier not used?

@Martin15135215
Copy link
Author

Martin15135215 commented Dec 24, 2023

I found the possible licence in the setup.py:

nbdev/setup.py

Lines 19 to 26 in 96deb7a

licenses = {
'apache2': ('Apache Software License 2.0','OSI Approved :: Apache Software License'),
'mit': ('MIT License', 'OSI Approved :: MIT License'),
'gpl2': ('GNU General Public License v2', 'OSI Approved :: GNU General Public License v2 (GPLv2)'),
'gpl3': ('GNU General Public License v3', 'OSI Approved :: GNU General Public License v3 (GPLv3)'),
'agpl3': ('GNU Affero General Public License v3', 'OSI Approved :: GNU Affero General Public License (AGPLv3)'),
'bsd3': ('BSD License', 'OSI Approved :: BSD License'),
}

First Question:

There is a GPL-3.0-only and GPL-3.0-or-later. what is with gpl3 meant?

Second Question:

How to change a licence in an already created nbdev project?

I did:

➤ nbdev_new
# Please enter a value for repo
repo = test
# Please enter a value for branch
branch = main
# Please enter a value for user
user = test
# Please enter a value for author

And then changed in the settings.ini the licence apache2 from to gpl3, however what do i need to do, that the Licence file changes?

Possible solution: #1391

Third Question:

How to create a nbdev project directly with GPL-3.0-only?

I did:

➤ nbdev_new --license gpl3
# Please enter a value for repo
repo = test
# Please enter a value for branch
branch = main
# Please enter a value for user
user = test
# Please enter a value for author
author = test
# Please enter a value for author_email
author_email = [email protected]
# Please enter a value for description
description = test

In the settings.ini, the value for licence was gpl3 however the licence file was still apache2?

So I did a quick check of the code for nbdev_new

def nbdev_new(**kwargs):

And I think with this URL only the template is downloaded

url = f"https://github.com/fastai/nbdev-template/archive/{tag}.tar.gz"

in the template is always with apach2 licence file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant