Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function def input parameter comments causing a "Javascript error" #1353

Open
lidar532 opened this issue Jun 13, 2023 · 1 comment
Open

Function def input parameter comments causing a "Javascript error" #1353

lidar532 opened this issue Jun 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@lidar532
Copy link

With the following in a code cell:

#| export
def XCORS_trim_to_time(
  f:str,
  start:str, 
  stop:str):
  pass

and this in a following cell:

show_doc(XCORS_trim_to_time)

I get the correct expected output:
image

But when inserting parameter comments as described in the
Nbdev video:

#| export
def XCORS_trim_to_time(
  f:str, # Filename
  start:str,  # Start time.
  stop:str):  # Stop time.
  pass
show_doc(XCORS_trim_to_time)

Below is a screencap of the resulting fail:
image

@lidar532 lidar532 added the bug Something isn't working label Jun 13, 2023
@deven-gqc
Copy link
Contributor

Hey @lidar532, this looks like an error because of some missing extensions in jupyterlab (not something that is caused because of nbdev). Can you install these extensions and try again?

image

With these extensions installed, you shouldn't get the javascript error again.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants