-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit code 1 when using a @call_parse CLI with a return #442
Comments
Yes it is intended, but I can see your argument that it's perhaps more annoying that helpful!... I guess if we removed it the alternative would be to use an Exception to create a non-zero exit code? |
I think an exception to create non-zero would be great. |
Fair enough! A PR for this functionality would be welcome. :) |
Using fastcore 1.5.10 I have been noticing some of my Github workflows failing with "Process completed with exit code 1" and no other error messages.
After playing around it seems that @call_parse decorated functions which return something cause this behaviour. A minimal example:
Now, at the command line:
That is, the first function fails while the second works fine. Is this intended? In my experience it can be useful to double up my CLI with general usage functions; currently I will need to use dedicated CLI functions which are not usable elsewhere in my code.
Thanks a lot in advance!
The text was updated successfully, but these errors were encountered: