Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"TypeError: Cannot read property 'join' of undefined" on sharing error #208

Open
regisb opened this issue Dec 6, 2022 · 0 comments
Open

Comments

@regisb
Copy link

regisb commented Dec 6, 2022

I incorrectly attempted to share a recording with a description that included double quote characters. This resulted in the following error:

$ terminalizer share launch.yml    
Please enter some details about your recording                                                 
? Title title                                
? Description ""
? Tags such as git,bash,game linux
                                               
/home/regis/venvs/node_modules/terminalizer/commands/share.js:201
        return reject(body.errors.join('\n'));
                                  ^                                                            

TypeError: Cannot read property 'join' of undefined

This error is caused by the fact that body is a string, not an object. It is resolved by adding body = JSON.parse(body); at the beginning of the request callback. Would you like me to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant