Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the skipvoid function may miss the true entry position #126

Open
ShijieYan opened this issue Sep 27, 2021 · 0 comments
Open

the skipvoid function may miss the true entry position #126

ShijieYan opened this issue Sep 27, 2021 · 0 comments
Labels

Comments

@ShijieYan
Copy link
Contributor

ShijieYan commented Sep 27, 2021

Based on the current implementation, a photon is moved '1' unit length forward before it lands inside a non-zero voxel and get traced back to the entry point of that voxel. The true entry position could be missed, as shown in the figure,
image
This is even more problematic in SVMC mode because it allows a photon propagate inside 0-labeled regions if a split voxel.

@fangq fangq added the bug label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants