Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in variant teeko #800

Open
yjf2002ghty opened this issue Jun 2, 2024 · 3 comments
Open

Crash in variant teeko #800

yjf2002ghty opened this issue Jun 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@yjf2002ghty
Copy link
Contributor

fairy-stockfish/variant-nnue-tools#19

In brief:
At evaluate.cpp:1301

                for (int j = 0; j < pos.connect_n(); j++)
                    if (pos.pieces(Us) & (s - j * d))
                        c++;
                score += make_score(200, 200)  * c / (pos.connect_n() - c) / (pos.connect_n() - c);   //////// Failed to handle pos.connect_n()=c condition
            }
        }
    }
@RainRat
Copy link
Contributor

RainRat commented Jun 2, 2024

Root cause is an optimization that didn't work right when variants inherit from each other. Fix is available at: https://github.com/fairy-stockfish/Fairy-Stockfish/pull/768/files#diff-af04472c8b7c849fcee248cf30695670e87f00f0b1f8763bd738823ee4f1258e

Temporary solution: Create a definition of Teeko that doesn't use any variant inheritance.

@Belzedar94
Copy link
Contributor

It's happening the same for variant: Symphony (NNUE datagen is crashing). I guess that's related, but if it isn't, I'll create a separate issue.

@RainRat
Copy link
Contributor

RainRat commented Jun 3, 2024

Try creating a definition that doesn't use inheritance, and if that fixes it, it's the same problem.

@ianfab ianfab added the bug Something isn't working label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants