Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ABFS): Add dependency for Auth support #11633

Closed
wants to merge 1 commit into from

Conversation

zhli1142015
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0961e5c
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6742fe131c84ba0008de59cc

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhli1142015 I change is needed as requested by Jacob.

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 25, 2024
@majetideepak majetideepak changed the title feat(ABFS): Add dep for ABFS Auth support feat(ABFS): Add dependency for ABFS Auth support Nov 25, 2024
@facebook-github-bot
Copy link
Contributor

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@majetideepak majetideepak changed the title feat(ABFS): Add dependency for ABFS Auth support feat(ABFS): Add dependency for Auth support Nov 25, 2024
@facebook-github-bot
Copy link
Contributor

@kagamiori merged this pull request in f33b40d.

Copy link

Conbench analyzed the 1 benchmark run on commit f33b40da.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

TongWei1105 pushed a commit to TongWei1105/velox that referenced this pull request Dec 3, 2024
…1633)

Summary: Pull Request resolved: facebookincubator#11633

Reviewed By: xiaoxmeng

Differential Revision: D66459525

Pulled By: kagamiori

fbshipit-source-id: 33d147ee030a90e72a8c4857233f38811ffb4a52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants