feat(ABFS): Support SAS and OAuth config #11623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhli1142015
requested review from
majetideepak and
assignUser
as code owners
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
cc @majetideepak , thanks. I offline verified this change. |
|
@zhli1142015 Thanks for this contribution! It is better to have a separate PR for the dependency change to test the code changes against a new image with these dependencies. |
|
I see, here is the Pr for dep update, please help review it. Thanks. |
zhli1142015
force-pushed
the
abfs_auth_more
branch
3 times, most recently
from
3460abc to
9cb4099
Compare
|
@majetideepak , could you help to review the change? |
zhli1142015
force-pushed
the
abfs_auth_more
branch
from
dd5de10 to
144b95d
Compare
zhli1142015
force-pushed
the
abfs_auth_more
branch
from
144b95d to
5401bb8
Compare
zhli1142015
force-pushed
the
abfs_auth_more
branch
from
5401bb8 to
bc6cc65
Compare
majetideepak
reviewed
Dec 2, 2024
minor change
zhli1142015
force-pushed
the
abfs_auth_more
branch
from
15271de to
fcaf015
Compare
majetideepak
reviewed
Dec 3, 2024
majetideepak
reviewed
Dec 3, 2024
majetideepak
reviewed
Dec 3, 2024
majetideepak
changed the title
majetideepak
reviewed
Dec 3, 2024
zhli1142015
force-pushed
the
abfs_auth_more
branch
from
aef376a to
ecce9fd
Compare
majetideepak
approved these changes
Dec 3, 2024
majetideepak
added
the
ready-to-merge
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in a0bbea2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.