Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FBOS to v2024.07.01 #11104

Closed

Conversation

czentgr
Copy link
Collaborator

@czentgr czentgr commented Sep 26, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 168ba3e
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/670449d94a160a0008d1900a

@czentgr czentgr force-pushed the cz_update_fbos_2024.07.01 branch from 4bd713b to f2045b7 Compare September 27, 2024 18:11
@czentgr czentgr changed the title [WIP] Update FBOS to v2024.07.01 Update FBOS to v2024.07.01 Sep 30, 2024
@czentgr czentgr force-pushed the cz_update_fbos_2024.07.01 branch from f2045b7 to d40111b Compare September 30, 2024 18:01
@czentgr
Copy link
Collaborator Author

czentgr commented Sep 30, 2024

@majetideepak My adapters image still has issues with the GCS tests but I think we can show that upgrading FBOS works fine as everything else passes.

Turns out the way I built the adapter container can't set the right conda environment and it just installs the testbench to the default env.

--> cd56c5d7dad3
STEP 8/15: SHELL ["mamba", "run", "-n", "adapters", "/bin/bash", "-c"]
time="2024-09-30T10:13:17-07:00" level=warning msg="SHELL is not supported for OCI image format, [mamba run -n adapters /bin/bash -c] will be ignored. Must use `docker` format"
--> 54ba5de2a294

which then results in the gcs test failure due to the missing pip dependency of testbench

 /opt/miniforge/envs/adapters/bin/python3: No module named testbench

@czentgr czentgr force-pushed the cz_update_fbos_2024.07.01 branch 2 times, most recently from a5bcddf to 05db195 Compare October 2, 2024 17:22
@czentgr czentgr marked this pull request as ready for review October 2, 2024 20:03
@czentgr
Copy link
Collaborator Author

czentgr commented Oct 2, 2024

@majetideepak @assignUser Please review. I will remove the last commit that changes the adapter images that used the new folly version now that we had a clean run.

Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @czentgr.

@majetideepak
Copy link
Collaborator

I will add the merge tag once the last commit has been removed.

@czentgr czentgr force-pushed the cz_update_fbos_2024.07.01 branch from 05db195 to 63ece32 Compare October 3, 2024 02:02
@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 3, 2024
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@czentgr czentgr force-pushed the cz_update_fbos_2024.07.01 branch from 63ece32 to 168ba3e Compare October 7, 2024 20:51
Copy link
Contributor

@kgpai kgpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @czentgr

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 3fabdf5.

Copy link

Conbench analyzed the 1 benchmark run on commit 3fabdf5c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants