Wave Metrics #10679
Closed
Wave Metrics #10679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oerling
commented
Aug 7, 2024
oerling
commented
- Make multithreaded memcpy for staging transfers for GPU table scan.
- Make variants of bit unpacking in GpuDecoder-inl.cuh. Make selective decoding templatized as opposed to runtime switching.
- Add pieces to GpuDecoderTest, like comparing calling via launchDecode or (multi-function blocks) or decodeGlobal (single function thread blocks).
- Add a metric for driver thread waiting for first continuable stream.
- Check approx correctness of Wave runtimeStats.
- Refactor QueryBenchmarkBase.* from TpchBenchmark. Logic to do sweeps across parameter combinations.
- Add persistent file format to Wave mock format.
- Add benchmark for scan, filter, filter expr, projection. aggregation combinations with Wave and Dwrf.
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D60880466 |
oerling
pushed a commit
to oerling/velox-1
that referenced
this pull request
Aug 7, 2024
Summary: - Make multithreaded memcpy for staging transfers for GPU table scan. - Make variants of bit unpacking in GpuDecoder-inl.cuh. Make selective decoding templatized as opposed to runtime switching. - Add pieces to GpuDecoderTest, like comparing calling via launchDecode or (multi-function blocks) or decodeGlobal (single function thread blocks). - Add a metric for driver thread waiting for first continuable stream. - Check approx correctness of Wave runtimeStats. - Refactor QueryBenchmarkBase.* from TpchBenchmark. Logic to do sweeps across parameter combinations. - Add persistent file format to Wave mock format. - Add benchmark for scan, filter, filter expr, projection. aggregation combinations with Wave and Dwrf. Pull Request resolved: facebookincubator#10679 Differential Revision: D60880466
oerling
force-pushed
the
wavemtr-pr
branch
2 times, most recently
from
1a2f4a5 to
4a20f55
Compare
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D60880466 |
oerling
pushed a commit
to oerling/velox-1
that referenced
this pull request
Aug 8, 2024
Summary: - Make multithreaded memcpy for staging transfers for GPU table scan. - Make variants of bit unpacking in GpuDecoder-inl.cuh. Make selective decoding templatized as opposed to runtime switching. - Add pieces to GpuDecoderTest, like comparing calling via launchDecode or (multi-function blocks) or decodeGlobal (single function thread blocks). - Add a metric for driver thread waiting for first continuable stream. - Check approx correctness of Wave runtimeStats. - Refactor QueryBenchmarkBase.* from TpchBenchmark. Logic to do sweeps across parameter combinations. - Add persistent file format to Wave mock format. - Add benchmark for scan, filter, filter expr, projection. aggregation combinations with Wave and Dwrf. Pull Request resolved: facebookincubator#10679 Differential Revision: D60880466 Pulled By: oerling
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: - Make multithreaded memcpy for staging transfers for GPU table scan. - Make variants of bit unpacking in GpuDecoder-inl.cuh. Make selective decoding templatized as opposed to runtime switching. - Add pieces to GpuDecoderTest, like comparing calling via launchDecode or (multi-function blocks) or decodeGlobal (single function thread blocks). - Add a metric for driver thread waiting for first continuable stream. - Check approx correctness of Wave runtimeStats. - Refactor QueryBenchmarkBase.* from TpchBenchmark. Logic to do sweeps across parameter combinations. - Add persistent file format to Wave mock format. - Add benchmark for scan, filter, filter expr, projection. aggregation combinations with Wave and Dwrf. Pull Request resolved: facebookincubator#10679 Differential Revision: D60880466 Pulled By: oerling
|
This pull request was exported from Phabricator. Differential Revision: D60880466 |
Yuhta
approved these changes
Aug 19, 2024
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
assignUser
reviewed
Aug 22, 2024
Comment on lines
-53
to
-55
| GTest::gtest | ||
| GTest::gtest_main | ||
| GTest::gmock |
There was a problem hiding this comment.
Please use the properly name spaced targets.
There was a problem hiding this comment.
I have fixed it in #10732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.