misc fixes for shared build

facebookincubator · Dec 6, 2024 · 9d15e53 · 9d15e53
1 parent 440da53
commit 9d15e53
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/velox/dwio/dwrf/test/utils/CMakeLists.txt b/velox/dwio/dwrf/test/utils/CMakeLists.txt
@@ -20,6 +20,7 @@ target_link_libraries(
   velox_dwio_common
   velox_dwio_common_exception
   velox_dwio_dwrf_reader
+  velox_dwio_common_test_utils
   velox_dwio_dwrf_writer
   velox_exception
   velox_memory

diff --git a/velox/flag_definitions/CMakeLists.txt b/velox/flag_definitions/CMakeLists.txt
@@ -11,5 +11,5 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-velox_add_library(velox_flag_definitions OBJECT flags.cpp)
+velox_add_library(velox_flag_definitions flags.cpp)
 velox_link_libraries(velox_flag_definitions PRIVATE gflags::gflags)
diff --git a/velox/tool/trace/CMakeLists.txt b/velox/tool/trace/CMakeLists.txt
@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-velox_add_library(
+add_library(
   velox_query_trace_replayer_base
   AggregationReplayer.cpp
   FilterProjectReplayer.cpp
@@ -23,7 +23,7 @@ velox_add_library(
   TableWriterReplayer.cpp
   TraceReplayRunner.cpp)
 
-velox_link_libraries(
+target_link_libraries(
   velox_query_trace_replayer_base
   velox_aggregates
   velox_type