Skip to content

Commit

Permalink
Fix arrow install with custom INSTALL_PREFIX (#11052)
Browse files Browse the repository at this point in the history
Summary:
If the recently added INSTALL_PREFIX does not point to /usr/local in Linux then the bundled Thrift installation from the Arrow dependency fails because it cannot locate Boost.

Boost was previously installed into the INSTALL_PREFIX but the Thrift CMake in Arrow does not pass on any PREFIX_PATH settings to Thrift. The PREFIX_PATH is set to the INSTALL_PREFIX and works with Arrow itself just fine.

The error would be

Could NOT find Boost (missing: Boost_INCLUDE_DIR) (Required is at least
  version "1.56")

Pull Request resolved: #11052

Reviewed By: bikramSingh91

Differential Revision: D64060501

Pulled By: xiaoxmeng

fbshipit-source-id: b393d9d0590828a8473a3f80ebc10d350fd3d20a
  • Loading branch information
czentgr authored and facebook-github-bot committed Oct 8, 2024
1 parent 683e359 commit 63c848d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion scripts/setup-centos9.sh
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,8 @@ function install_arrow {
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
-DCMAKE_BUILD_TYPE=Release \
-DARROW_BUILD_STATIC=ON \
-DThrift_SOURCE=BUNDLED
-DThrift_SOURCE=BUNDLED \
-DBOOST_ROOT=${INSTALL_PREFIX}

(
# Install thrift.
Expand Down
3 changes: 2 additions & 1 deletion scripts/setup-ubuntu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ function install_arrow {
-DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \
-DCMAKE_BUILD_TYPE=Release \
-DARROW_BUILD_STATIC=ON \
-DThrift_SOURCE=BUNDLED
-DThrift_SOURCE=BUNDLED \
-DBOOST_ROOT=${INSTALL_PREFIX}

(
# Install thrift.
Expand Down

0 comments on commit 63c848d

Please sign in to comment.