Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

isValid does not work for delayed #200

Open
jstastny opened this issue Jan 12, 2017 · 1 comment
Open

isValid does not work for delayed #200

jstastny opened this issue Jan 12, 2017 · 1 comment

Comments

@jstastny
Copy link
Contributor

When isValid method is called from https://github.com/facebook/mention-bot/blob/master/server.js#L405, if passes the currentData, which does not contain the data format expected by isValid.

I am already trying to fix this and will prepare PR. The validation will most likely have to be split to validation on PR level and validation done on the event level. The delayed function will only call the PR validation as it does not have enough data for the other validation.

@vjeux
Copy link
Contributor

vjeux commented Jan 12, 2017

Good catch. I'm happy to review a pull request if you can get it working :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants