Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

Having Trouble With Demo Bot #187

Open
nruhe opened this issue Nov 27, 2016 · 4 comments
Open

Having Trouble With Demo Bot #187

nruhe opened this issue Nov 27, 2016 · 4 comments

Comments

@nruhe
Copy link

nruhe commented Nov 27, 2016

Hey everyone! I'm having some difficulty getting the demo to work. I'm just trying to get it to comment so I can make some basic config files for my team.

I made a test repo here, and I opened a PR here. I then added a webhook pointing to the bot, and I gave it the proper permissions. It successfully shows post requests being sent to the bot, but still no actual comment in my PR. Any idea what I'm doing wrong? Is it not sending it because I'm the creator and there are no collaborators?

@vjeux
Copy link
Contributor

vjeux commented Nov 27, 2016

Hey, thanks for reaching out!

I think that there are two issues here:

  1. .mention-bot file only accepts valid json and our example in the README is not because there's a trailing comma and comments. Refs #185, remove trailing comma for .mention-bot file before JSON parse #186 (comment) is tracking sending a message when the file has an invalid format.

  2. mention-bot doesn't mention yourself. Can you find someone to do a commit on the file you are trying to modify such that it appears in the blame?

Sorry about that! Hopefully after those two things it'll work for you!

@nruhe
Copy link
Author

nruhe commented Nov 27, 2016

Ah, thank you very much. I'll give that a try! :)

On a side note, do you think that point 2 could be added to the readme as a note @vjeux? I can't be the only person who has gotten confused why the bot isn't responding. The demo seems to imply that it will work right out of the box for every commit. In hindsight though...I suppose that makes a lot of sense...no need to mention yourself...

@vjeux
Copy link
Contributor

vjeux commented Nov 27, 2016

Would love if you could send a pull request to put it where you would have likely read it :)

@nruhe
Copy link
Author

nruhe commented Nov 27, 2016

I'll try to make sure to do that. :)

On another note, no dice sadly @vjeux: https://github.com/nruhe/test-mention-bot/pull/9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants