Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental debugger does not work on 0.74 with bridgeless on iOS #44240

Open
gabrieldonadel opened this issue Apr 24, 2024 · 0 comments · May be fixed by #44257
Open

Experimental debugger does not work on 0.74 with bridgeless on iOS #44240

gabrieldonadel opened this issue Apr 24, 2024 · 0 comments · May be fixed by #44257
Assignees
Labels
p: Expo Partner: Expo Partner Platform: iOS iOS applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@gabrieldonadel
Copy link
Contributor

gabrieldonadel commented Apr 24, 2024

Description

After creating a fresh app with npx react-native init HermesTest and enabling the new architecture on iOS, users are unable to use the experimental debugger and are faced with a warning in the terminal saying No compatible apps connected. JavaScript debugging can only be used with the Hermes engine

Steps to reproduce

  1. Start the app enabling the new debugger. e.g. yarn start --experimental-debugger
  2. iOS open the dev menu and click on "Open Debugger"
  3. Nothing happens

React Native Version

0.74.0

Affected Platforms

Runtime - iOS

Areas

Bridgeless - The New Initialization Flow

Output of npx react-native info

System:
  OS: macOS 14.0
  CPU: (12) arm64 Apple M2 Max
  Memory: 172.27 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.11.1
    path: ~/.volta/tools/image/node/20.11.1/bin/node
  Yarn:
    version: 1.22.22
    path: ~/.volta/tools/image/yarn/1.22.22/bin/yarn
  npm:
    version: 10.2.4
    path: ~/.volta/tools/image/node/20.11.1/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/gabriel/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK:
    API Levels:
      - "22"
      - "26"
      - "30"
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 26.0.3
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 33.0.1
      - 33.0.2
      - 34.0.0
    System Images:
      - android-22 | ARM 64 v8a
      - android-26 | Google APIs Intel x86_64 Atom
      - android-28 | Google ARM64-V8a Play ARM 64 v8a
      - android-30 | ARM 64 v8a
      - android-33 | Google APIs ARM 64 v8a
      - android-33 | Google Play ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11567975
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8
    path: /usr/bin/javac
  Ruby:
    version: 2.7.8
    path: /Users/gabriel/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.0
    wanted: 0.74.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

BUNDLE  ./index.js ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░ 95.1% (556/570)  Metro:InspectorProxy Got new connection: name=iPhone 15 Pro, app=org.reactjs.native.example.HermesTest, device=178750f3068b8a767e66c96bb3c7ba81b793c663 +0ms
 (NOBRIDGE) LOG  Bridgeless mode is enabled
 (NOBRIDGE) LOG  Running "HermesTest" with {"rootTag":1,"initialProps":{"concurrentRoot":true},"fabric":true}
  Metro:InspectorProxy (Debugger)    (Proxy) <- (Device), getPages ping has changed: {"event":"getPages","payload":[]} +1s
info Launching JS debugger (experimental)...
warn No compatible apps connected. JavaScript debugging can only be used with the Hermes engine.

Reproducer

https://github.com/gabrieldonadel/hermes-debugger-broken-074

Screenshots and Videos

Screen.Recording.2024-04-24.at.11.01.55.mov
@gabrieldonadel gabrieldonadel added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels Apr 24, 2024
@github-actions github-actions bot added the Platform: iOS iOS applications. label Apr 24, 2024
@huntie huntie self-assigned this Apr 24, 2024
cipolleschi added a commit to cipolleschi/react-native that referenced this issue Apr 25, 2024
Summary:
Set the proper build flags for debugging in Bridgeless mode.

This fixes [facebook#44240](facebook#44240)

## Changelog:
[iOS][Fixed] - Add `HERMES_ENABLE_DEBUGGER=1` flag to React-RuntimeApple

Differential Revision: D56575647
@cipolleschi cipolleschi linked a pull request Apr 25, 2024 that will close this issue
facebook-github-bot pushed a commit that referenced this issue Apr 25, 2024
Summary:
Set the proper build flags for debugging in Bridgeless mode.

This fixes [#44240](#44240)

## Changelog:
[iOS][Fixed] - Add `HERMES_ENABLE_DEBUGGER=1` flag to React-RuntimeApple

Reviewed By: cortinico

Differential Revision: D56575647

fbshipit-source-id: a0613a5d46caeb1d3e636e54ecd43428fbaf46e8
Titozzz pushed a commit that referenced this issue Apr 29, 2024
Summary:
Set the proper build flags for debugging in Bridgeless mode.

This fixes [#44240](#44240)

## Changelog:
[iOS][Fixed] - Add `HERMES_ENABLE_DEBUGGER=1` flag to React-RuntimeApple

Reviewed By: cortinico

Differential Revision: D56575647

fbshipit-source-id: a0613a5d46caeb1d3e636e54ecd43428fbaf46e8
cipolleschi added a commit that referenced this issue May 1, 2024
Summary:
Set the proper build flags for debugging in Bridgeless mode.

This fixes [#44240](#44240)

## Changelog:
[iOS][Fixed] - Add `HERMES_ENABLE_DEBUGGER=1` flag to React-RuntimeApple

Reviewed By: cortinico

Differential Revision: D56575647

fbshipit-source-id: a0613a5d46caeb1d3e636e54ecd43428fbaf46e8
kosmydel pushed a commit to kosmydel/react-native that referenced this issue May 6, 2024
Summary:
Set the proper build flags for debugging in Bridgeless mode.

This fixes [facebook#44240](facebook#44240)

## Changelog:
[iOS][Fixed] - Add `HERMES_ENABLE_DEBUGGER=1` flag to React-RuntimeApple

Reviewed By: cortinico

Differential Revision: D56575647

fbshipit-source-id: a0613a5d46caeb1d3e636e54ecd43428fbaf46e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: Expo Partner: Expo Partner Platform: iOS iOS applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants