Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyre couldn't find a required site-package #773

Open
WangGithubUser opened this issue Aug 9, 2023 · 1 comment · May be fixed by #781
Open

Pyre couldn't find a required site-package #773

WangGithubUser opened this issue Aug 9, 2023 · 1 comment · May be fixed by #781

Comments

@WangGithubUser
Copy link
Contributor

WangGithubUser commented Aug 9, 2023

Pyre Bug

Bug description
Pyre can't find a Python Extension Module (.pyd) package in site-package

Reproduction steps
Run pyre with the following .pyre_configuration:

{
  "site_package_search_strategy": "pep561",
  "source_directories": [
    "."
  ],
  "search_path": [
    {
      "site-package": "ujson"
    }
  ],
  "taint_models_path": "Secret",
  "typeshed": "Secret"
}

Expected behavior
It should pass but not warning ƛ Site package does not exist: `ujson`

Logs

pyre check
ƛ Site package does not exist: `ujson`
ƛ No type errors found

Additional context
This may due to pyre do not treat .pyd files(actully all the files that not have .py shuffix) as a package.

@WangGithubUser
Copy link
Contributor Author

WangGithubUser commented Aug 10, 2023

Fix suggestion: Every site-package must have a name-version.dist-info folder in the site root, and there will be a RECORD file in the folder.
image

And all the files will be listed in the RECORD file, so we can filter them out.

@WangGithubUser WangGithubUser linked a pull request Aug 21, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant