Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determin secondary index value emptiness by datadic #1440

Open
rockeet opened this issue Mar 17, 2024 · 0 comments
Open

Determin secondary index value emptiness by datadic #1440

rockeet opened this issue Mar 17, 2024 · 0 comments

Comments

@rockeet
Copy link
Contributor

rockeet commented Mar 17, 2024

In most cases, secondary index values are empty, thus rocks_iter->value() is not needed in such cases.

We realized an SST with lazy load of value, this is a big improvement for large values.

When value is small(even empty), lazy load is less useful, but the calling chain is still needed, in our optimized rocksdb branch, in iter scan, it is about 70~90ns per kv-pair, in which the iter->value() is about 11ns for empty value.

If secondary index value emptiness can be identified by datadic, the iter->value() can be omitted, this is a reasonable optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant