{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":9454675,"defaultBranch":"fb-mysql-8.0.32","name":"mysql-5.6","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-04-15T17:54:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715620913.0","currentOid":""},"activityList":{"items":[{"before":"a930da0e5a6e94d0c0187ea0685561cf19a500a7","after":"61bba3c452ab4b36b8eef16aa0eacbc5bd6eba10","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T22:04:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"update sys.sys_config table for rocksdb DDSE (#1455)\n\nSummary:\nCurrently there are few tables still running INNDOB. and sys.sys_config table is one of them. although sys.sys_config table doesn't belong to DD table or SYSTEM TABLE, also convert this table into RocksDB table\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1455\n\nDifferential Revision: D57264957\n\nfbshipit-source-id: 47f579d568bccb522902675808b294c1a77d3f75","shortMessageHtmlLink":"update sys.sys_config table for rocksdb DDSE (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2293817563\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1455\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1455/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1455\">#1455</a>)"}},{"before":"03b744a26bf360b4c9fcd9ee7d906580d18aadea","after":"a930da0e5a6e94d0c0187ea0685561cf19a500a7","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T20:45:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Merge all the no-op MyRocks system variable update functions (#1454)\n\nSummary:\nCode removal, they differed only by their names.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1454\n\nDifferential Revision: D57355151\n\nfbshipit-source-id: d3432152d2b85a762dc9a0660e2d3ff5e73e9769","shortMessageHtmlLink":"Merge all the no-op MyRocks system variable update functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2289169573\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1454\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1454/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1454\">#1454</a>)"}},{"before":"0b48403fd65606732b503fa2aa9c0bb1d35b4411","after":"03b744a26bf360b4c9fcd9ee7d906580d18aadea","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T17:47:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove Rdb_transaction::m_is_tx_failed field (#1453)\n\nSummary:\nIts sole purpose was to handle rollbacks of single-statement autocommit\ntransactions: first, rocksdb_rollback rolled back the statement itself, set the\nflag, and then ha_rocksdb::external_lock used the flag to roll back the whole\ntransaction.\n\nSimplify this by rolling back the whole transaction in rocksdb_rollback, and\nletting ha_rocksdb::external_lock to always call commit, which DTRT on\nrolled-back transactions too.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1453\n\nDifferential Revision: D57113570\n\nfbshipit-source-id: 3566424608fc9453767b6816729ac688e4df628a","shortMessageHtmlLink":"Remove Rdb_transaction::m_is_tx_failed field (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2282548431\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1453\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1453/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1453\">#1453</a>)"}},{"before":"329588bdd15e6ed0b247259f6697db43e0b376bd","after":"0b48403fd65606732b503fa2aa9c0bb1d35b4411","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T13:25:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Return error if range queries don't include LIMIT clause\n\nSummary:\nWe expect by design that all bypass rpc range query should have limit clause.\n(Note that bypass rpc doesn't support streaming result.)\nLet's return error if bypass rpc range query doesn't include limit clause.\n\nDifferential Revision: D57333989\n\nfbshipit-source-id: ec07dc87e04ce9c98ba8148785b69b382c663a79","shortMessageHtmlLink":"Return error if range queries don't include LIMIT clause"}},{"before":"769db5bbabbc1df31d0be21f4d9af2799b3aac57","after":"329588bdd15e6ed0b247259f6697db43e0b376bd","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T01:24:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix rocksdb.singledelete by exclude system cf table stats in the test\n\nSummary:\nrocksdb.singledelete has been unstable because the stats it relies on getting updated by none user tables (DD tables when DDSE is rocksdb).\n- introduce a variable to skip collecting stats for system cf which DD tables are in\n- set the variable in the test\n- remove previous fix attempts in the test\n\nDifferential Revision: D57424255\n\nfbshipit-source-id: cf58823c339dd68b45309fa417d63adbc437603c","shortMessageHtmlLink":"fix rocksdb.singledelete by exclude system cf table stats in the test"}},{"before":"347b71f5dcb60fbdbecf05e19da688479e70c06a","after":"769db5bbabbc1df31d0be21f4d9af2799b3aac57","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-16T00:17:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not hold index lock during network write for 'show binary|raft logs'\n\nSummary:\nCurrently, show binary|raft logs holds index lock while sending information to clients. If the client is stuck, index lock will be held for an extended period time, which will block flush and subsequence writes.\n\nThe proper fix is to cache binary log information, release index lock, then send the information to client.\n\nBelow is an easy repro\nStep 1\n```\nmysql --no-defaults -S /home/chili/mysql/mysql80-fork/_build-8.0-Debug/mysql-test/var/tmp/mysqld.1.sock -u root -D test  -e \"show binary logs with gtid\" --quick | sleep 100\n```\nStep 2\n```\nflush binary log;\n```\nStep 3\n```\nmysql> insert into t values(0);\nQuery OK, 1 row affected (44.28 sec)\n```\n\nDifferential Revision: D57355780\n\nfbshipit-source-id: 96fac64a2536293969488ec2154978f2444ec35f","shortMessageHtmlLink":"Do not hold index lock during network write for 'show binary|raft logs'"}},{"before":"9794eb5b479c87cde267b1b453e90d3894626e20","after":"347b71f5dcb60fbdbecf05e19da688479e70c06a","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-15T04:37:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Avoid aborting server when purge_logs() clashes with rli_relay_log_raft_reset()\n\nSummary:\nWithin purge_logs(), after we purge binlogs, it needs to update the binlog's index file. It does this in a crashproof manner within move_crash_safe_index_file_to_index_file() which makes a copy of the index file, modifies it, deletes original index file and renames copied index file in place of the original index file. We abort the server when the rename fails. The rename fails because rli_relay_log_raft_reset() can be running, which restores the index file.\n\nTo avoid this, rli_relay_log_raft_reset() should acquire the global mysql_bin_log's index lock.\n\nSince rli_relay_log_raft_reset() is called when we transition from primary to secondary, I feel it is OK to take a hit on grabbing the index lock.\n\nDifferential Revision: D57198631\n\nfbshipit-source-id: 88a08f1658b736fcf4af41e2c215e858f1d1d9b3","shortMessageHtmlLink":"Avoid aborting server when purge_logs() clashes with rli_relay_log_ra…"}},{"before":"543fc1a32fcfb39a06b4a9ee10117e5bfd18e71c","after":"9794eb5b479c87cde267b1b453e90d3894626e20","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-13T23:55:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"consolidate vectordb write path with sk write\n\nSummary: consolidate vectordb write path to use the same flow as other SKs\n\nDifferential Revision: D57029524\n\nfbshipit-source-id: 5290dd9d3f9ae5a54709c874accf23aea53c33e1","shortMessageHtmlLink":"consolidate vectordb write path with sk write"}},{"before":"8826b9b444c886f6d1e277a025b8131025bd5f87","after":null,"ref":"refs/heads/fbcode-sync-test2-8.0.32","pushedAt":"2024-05-13T17:21:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hermanlee","name":"Herman Lee","path":"/hermanlee","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6656176?s=80&v=4"}},{"before":"3a47b3d52036cb3f69ea8159e4e8abfea0726b4a","after":null,"ref":"refs/heads/fbcode-sync-test-8.0.32","pushedAt":"2024-05-13T17:21:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hermanlee","name":"Herman Lee","path":"/hermanlee","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6656176?s=80&v=4"}},{"before":"0798f2a4fe665b9c04a5cf25dd0c8624f79beeb1","after":"543fc1a32fcfb39a06b4a9ee10117e5bfd18e71c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-13T16:11:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix async memory references\n\nSummary:\nAsync structures could be freed by calls to end_server. Subsequent reset\ncalls were referencing freed memory, so validate the pointer before\nreferencing the memory.\n\nDifferential Revision: D57280022\n\nfbshipit-source-id: 76110822445377f2c27cf619c9c17cbba9a439c7","shortMessageHtmlLink":"Fix async memory references"}},{"before":"bae466c2ab791209a4a06d0e6a95395ab11b86c2","after":"8826b9b444c886f6d1e277a025b8131025bd5f87","ref":"refs/heads/fbcode-sync-test2-8.0.32","pushedAt":"2024-05-11T20:32:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"fbshipit-source-id: 0ff08e4ca8f5","shortMessageHtmlLink":"fbshipit-source-id: 0ff08e4ca8f5"}},{"before":null,"after":"bae466c2ab791209a4a06d0e6a95395ab11b86c2","ref":"refs/heads/fbcode-sync-test2-8.0.32","pushedAt":"2024-05-11T20:25:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"[mysql-5.6][PR] Convert newly-added default_dd_storage_engine uses to default_dd_system_storage_engine\n\nSummary:\nTwo PRs https://github.com/facebook/mysql-5.6/pull/1396 and https://github.com/facebook/mysql-5.6/pull/1394 were merged at the same time, whereas the second one to go in needed a rebase.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1402\nGitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com>\n\nTest Plan: CI\n\nReviewers: herman, #mysql_eng\n\nReviewed By: herman\n\nDifferential Revision: https://phabricator.intern.facebook.com/D51815181","shortMessageHtmlLink":"[mysql-5.6][PR] Convert newly-added default_dd_storage_engine uses to…"}},{"before":"d993fa45c8bc8a0e6e790a0c8d6b8e564ce7dbbf","after":"0798f2a4fe665b9c04a5cf25dd0c8624f79beeb1","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-10T22:49:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix debug assertion in net_write_command_nonblocking()\n\nSummary:\nThe client application calls mysql_close() to shutdown connections.\nmysql_close() attempts to send a COM_QUIT during this process regardless\nof the current state of the connection.\n\nIn debug mode, this trips an assertion in net_write_command_nonblocking\nif the async connection was still actively waiting in the read state for\ndata from the server.\n\nSince it's expected for the async cleanup to send out COM_QUIT during\nshutdown, and since shutdown can happen at any point in time when the\nclient times out, fix the assert to check the command.\n\nDifferential Revision: D57231183\n\nfbshipit-source-id: 1903e021ce7c65cd3cbd4ed179b68731830db9bf","shortMessageHtmlLink":"Fix debug assertion in net_write_command_nonblocking()"}},{"before":"e5164140e72bd9abc1ec769676725a702d8bcc52","after":"d993fa45c8bc8a0e6e790a0c8d6b8e564ce7dbbf","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-10T04:37:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make vector index column vector_dimension attribute mandatory\n\nSummary: vector index will only support columns with vector_dimension attribute.\n\nDifferential Revision: D57029602\n\nfbshipit-source-id: 26d716de1adc13baf36dc37f20f4234744d98f45","shortMessageHtmlLink":"make vector index column vector_dimension attribute mandatory"}},{"before":"bae466c2ab791209a4a06d0e6a95395ab11b86c2","after":"3a47b3d52036cb3f69ea8159e4e8abfea0726b4a","ref":"refs/heads/fbcode-sync-test-8.0.32","pushedAt":"2024-05-09T21:22:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"fbshipit-source-id: 708d381e2b94","shortMessageHtmlLink":"fbshipit-source-id: 708d381e2b94"}},{"before":null,"after":"bae466c2ab791209a4a06d0e6a95395ab11b86c2","ref":"refs/heads/fbcode-sync-test-8.0.32","pushedAt":"2024-05-09T18:49:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"[mysql-5.6][PR] Convert newly-added default_dd_storage_engine uses to default_dd_system_storage_engine\n\nSummary:\nTwo PRs https://github.com/facebook/mysql-5.6/pull/1396 and https://github.com/facebook/mysql-5.6/pull/1394 were merged at the same time, whereas the second one to go in needed a rebase.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1402\nGitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com>\n\nTest Plan: CI\n\nReviewers: herman, #mysql_eng\n\nReviewed By: herman\n\nDifferential Revision: https://phabricator.intern.facebook.com/D51815181","shortMessageHtmlLink":"[mysql-5.6][PR] Convert newly-added default_dd_storage_engine uses to…"}},{"before":"27c5a3c201c0c36ae6a025f849a02c673205c01d","after":"e5164140e72bd9abc1ec769676725a702d8bcc52","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-09T17:31:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add functions to retrieve and set SSL sessions for connections\n\nSummary:\nPort forward the ssl_session feature to 8.0.28. While similar\nfunctionality via ssl_session_data is provided, it is more difficult to\nintegrate due to management of the ssl_session_data memory since\nexisting APIs call SESSION_SSL_free directly.\n\nMost of the code has already been added by the ssl_session_data\ncodepath. This adds the API to fetch and set the ssl_session parameter.\nDuring connection setup, ssl_session is used before ssl_session_data.\n\nReference patch: https://github.com/facebook/mysql-5.6/commit/2e261e6\n\nDifferential Revision: D57133792\n\nfbshipit-source-id: d030b2ee40bd8a21e43145a4be1c20945b7cd8fe","shortMessageHtmlLink":"Add functions to retrieve and set SSL sessions for connections"}},{"before":"2e6aaeb606f97a84e18bfb81c4e2a4f85b5bdf86","after":"27c5a3c201c0c36ae6a025f849a02c673205c01d","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-09T16:04:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix server crash in Rdb_index_stats_thread analyze vector index\n\nSummary:\n- when vector index analyze method is called from Rdb_index_stats_thread, thd is null, which will causing crash later on\n- check thd before calling the method\n\nDifferential Revision: D57135608\n\nfbshipit-source-id: 027f73979191e8b7132df245a4378a9af94d1171","shortMessageHtmlLink":"fix server crash in Rdb_index_stats_thread analyze vector index"}},{"before":"a002bf7f4e8089992cc2e10bedea096e1b38fa31","after":"2e6aaeb606f97a84e18bfb81c4e2a4f85b5bdf86","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-07T21:28:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove SASL env var\n\nSummary: We're removing the sasl plugin. So we don't need this anymore.\n\nDifferential Revision: D57031884\n\nfbshipit-source-id: 3969512fed6322014325ff11f4eb1eaf421ab806","shortMessageHtmlLink":"Remove SASL env var"}},{"before":"16c8cfc63aefb2743b324e9f54c2675ed3b32bfa","after":"a002bf7f4e8089992cc2e10bedea096e1b38fa31","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-07T16:53:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating RocksDB to 9.2.fb\n\nSummary:\nThis diff updates RocksDB revision from 9.1.fb to 9.2.fb.\n\nupdate-submodule: rocksdb\n\nDifferential Revision: D57004236\n\nfbshipit-source-id: e7ebd1006a2a41a9a3ba1db7fdfca9b0c96429d8","shortMessageHtmlLink":"Updating RocksDB to 9.2.fb"}},{"before":"ce211faf772e0df52dc3f4ff5be480f50d3c6c65","after":"16c8cfc63aefb2743b324e9f54c2675ed3b32bfa","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-04T00:23:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add SESSION_SYSVARS_TRACKER to st_ok_metadata upon tracker change\n\nSummary: Add MTR tests now that D56169813 D56169278 have landed.\n\nDifferential Revision: D56802898\n\nfbshipit-source-id: 99dced69290d8e4388f24df9dbaeea0eaad5df37","shortMessageHtmlLink":"Add SESSION_SYSVARS_TRACKER to st_ok_metadata upon tracker change"}},{"before":"e38937cd5a8ae5d79586dfeb05041e3457887b33","after":"ce211faf772e0df52dc3f4ff5be480f50d3c6c65","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-02T21:53:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"update instant ddl variables for myrocks\n\nSummary:\nPrevious the variable name rocksdb_disable_instant_ddl is confusing.  Use rocksdb_enable_instant_ddl  instead and  deprecate rocksdb_disable_instant_ddl. rocksdb_enable_instant_ddl is for emergency use to turn off all instant-ddl knobs.\n\nadd a new variable rocksdb-enable-instant-ddl-for-append-column to enable/disable append column DDL scenario.\n\nIn future, each instant scenario should add its own switch to control whether support that scenario.\n\nNOTE: These INSTANT variables are only to control future INSTANT DDLs behavior. Doesn't affect the DDL has been committed.\n\nDifferential Revision: D53697104\n\nfbshipit-source-id: 31fc60f0f60bdb5950164d5c055d5064d635f27e","shortMessageHtmlLink":"update instant ddl variables for myrocks"}},{"before":"eba5163c57c16d868a920f24bee3715ce38ec006","after":"e38937cd5a8ae5d79586dfeb05041e3457887b33","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-01T05:13:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fb_vector_dimension column attribute\n\nSummary:\nintroduce fb_vector_dimension column attribute to indicate a column contains vector data\n\nwith this attribute, the server\n- checks the column is 'JSON NOT NULL'\n- checks the column contains a valid vector with specified dimension\n- these checks are performed when setting the field before storage engine\n\nif vector index is created on such column, the vector index dimension value is set with the column's dimension value. in the future, vector index will require column to have this attribute.\n\nDifferential Revision: D56664387\n\nfbshipit-source-id: 695d3bf92d9c98cc3c09b900bc189233578475be","shortMessageHtmlLink":"fb_vector_dimension column attribute"}},{"before":"8173866e1850f4814def1ffb91c662be6d91d572","after":"eba5163c57c16d868a920f24bee3715ce38ec006","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-04-30T18:21:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Disable binlog.binlog_mysqlbinlog_source_gipk_info (#1448)\n\nSummary:\nMeta's patch has changed the table map log event and this test uses\npre-generated upstream ones, which are incompatible. It would be possible to\nrecreate pre-generated events in Meta format, but there is little value in\nrestoring the functionality of this test anyway.\n\nSquash with e13fd4103d3c9347aedf9cad02a2b7e445288413\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1448\n\nDifferential Revision: D56589203\n\nfbshipit-source-id: 5132ab38b423dd37650a6accea1c6249d088a71e","shortMessageHtmlLink":"Disable binlog.binlog_mysqlbinlog_source_gipk_info (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2255914281\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1448\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1448/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1448\">#1448</a>)"}},{"before":"f0108427fb4704ad203516284cf2614233f8253d","after":"8173866e1850f4814def1ffb91c662be6d91d572","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-04-30T04:19:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add SESSION_SYSVARS_TRACKER to st_ok_metadata upon tracker change\n\nSummary:\n### Background\nBased on https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_session_track_system_variables, session_track_system_variables will detect the change of the system value `time_zone, autocommit, character_set_client, character_set_results, character_set_connection`.\n\nThrift server plugin needs this tracker's information to decide if these sysvar have been changed and what the new values are. If so, it will reset sessions.\n\n### Approach\n- I moved Session_sysvars_tracker definition and part of impl from .cc to .h to be able to cast that in `sql/sql_class.cc`.\n- Added populate_changed_sysvars helper function in Session_sysvars_tracker.\n\nDifferential Revision: D56169278\n\nfbshipit-source-id: a980dd8d10db21c195d3e27d1f7314d495e2ca9a","shortMessageHtmlLink":"Add SESSION_SYSVARS_TRACKER to st_ok_metadata upon tracker change"}},{"before":"05605eac64ce2788856c7b4d5a58b966a3480456","after":"f0108427fb4704ad203516284cf2614233f8253d","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-04-29T20:22:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"replace python with python3 for cpplint.py\n\nSummary: For cpplint.py, use python3 instead of python2\n\nDifferential Revision: D56717362\n\nfbshipit-source-id: bc9309da7d0ea0827578d04cab6e25b3a9f86eca","shortMessageHtmlLink":"replace python with python3 for cpplint.py"}},{"before":"1271283895eb9e08595a3d19d2a31e4bacd9827f","after":"05605eac64ce2788856c7b4d5a58b966a3480456","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-04-29T18:00:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Switch crc32_z to crc32\n\nSummary: Change to crc32 to support other versions.\n\nDifferential Revision: D56586899\n\nfbshipit-source-id: 283557daf3c96a0f6ea3bfe947fddd67b449b765","shortMessageHtmlLink":"Switch crc32_z to crc32"}},{"before":"b09f052510c5ac360fb6e30ef3f24ab2d915a7f2","after":"1271283895eb9e08595a3d19d2a31e4bacd9827f","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-04-29T05:24:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"record for --rocksdb-debug-skip-bloom-filter-check-on-iterator-bounds\n\nSummary: As title\n\nDifferential Revision: D56677115\n\nfbshipit-source-id: 14febe3f52bd7e61219897d9e0e201c0f074ead7","shortMessageHtmlLink":"record for --rocksdb-debug-skip-bloom-filter-check-on-iterator-bounds"}},{"before":"ec74bef8f3fca5633403cf2dae9e9f5541b0eff6","after":"b09f052510c5ac360fb6e30ef3f24ab2d915a7f2","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-04-28T18:08:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pass ColumnFamilyHandle around by reference; wrap Iterator in unique_ptr (#1445)\n\nSummary:\nIn preparation for the range locking patch, clean up some code related to\niterators:\n- Pass rocksdb::ColumnFamilyHandle around and store in classes by references\n  instead of pointers. It is never nullptr, nor is ever reseated in the classes\n  using it.\n- Wrap the rocksdb::Iterator objects in std::unique_ptr: change the factory\n  method return types and class fields.\n- In both cases above mark the classes containing reference fields as\n  non-copyable and non-moveable as needed, matching their current usage.\n- Mark touched methods [[nodiscard]] as applicable. In rdb_index_merge.h, remove\n  many instances of redundant MY_ATTRIBUTE((__nonnull__)) too.\n- Make touched local vars auto, but with reference or pointer pulled out,\n  sometimes avoiding redundant returned object copies.\n- Remove redundant instances of const from passed-by-value arguments.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1445\n\nDifferential Revision: D56051402\n\nfbshipit-source-id: 82f67c712a3ddf1cbc38db1d78c86c9be00dc16e","shortMessageHtmlLink":"Pass ColumnFamilyHandle around by reference; wrap Iterator in unique_…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETVLljwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/mysql-5.6"}