From 33017d6b13f9dbd7db74116f286027cdb61ab679 Mon Sep 17 00:00:00 2001 From: Pranjal Raihan Date: Fri, 10 Jan 2025 03:55:58 -0800 Subject: [PATCH] Update doc around function support Summary: These are now supported fully! Reviewed By: vitaut Differential Revision: D67996077 fbshipit-source-id: 30448a3612e622c6a8c8b5a8785ca263dd989ba3 --- thrift/compiler/whisker/object.h | 2 ++ thrift/doc/contributions/whisker.md | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/thrift/compiler/whisker/object.h b/thrift/compiler/whisker/object.h index ea0ef698c79..78dfcbd9329 100644 --- a/thrift/compiler/whisker/object.h +++ b/thrift/compiler/whisker/object.h @@ -53,6 +53,8 @@ namespace whisker { // identifier, and the value is a `whisker::object` (recursive) // * native_object — // User-defined (C++) type with lazily evaluated properties. +// * native_function — +// User-defined (C++) function that operates on `whisker::object`. // // Currently, the Whisker templating language only supports i64, null, string, // and boolean as literals. However, the evaluation engine can recognize all of diff --git a/thrift/doc/contributions/whisker.md b/thrift/doc/contributions/whisker.md index b24bfbb8d6e..b68f44d6206 100644 --- a/thrift/doc/contributions/whisker.md +++ b/thrift/doc/contributions/whisker.md @@ -176,10 +176,6 @@ There are three types of `expression`s in Whisker: * `{{ (uppercase "hello") }}` * `{{ (concat (uppercase person.firstName) " " (uppercase person.lastName)) }}` -:::warning -Function call expressions are only partially implemented. -::: - :::note The `and` and `or` builtin functions short-circuit their evaluation, meaning additional arguments will not be evaluated or checked for errors once the result is determined. :::