Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NPM package publishing sane with Lerna #90

Closed
jrwats opened this issue Oct 15, 2019 · 1 comment
Closed

Make NPM package publishing sane with Lerna #90

jrwats opened this issue Oct 15, 2019 · 1 comment
Assignees
@jrwats
Labels
enhancement New feature or request

Comments

@jrwats
Copy link
Contributor

jrwats commented Oct 15, 2019 •
edited

Our NPM publishing is hairy and easy to get wrong. That, and it'd be nice to get CHANGELOG updates for free via lerna-changelog.
@jrwats jrwats added the enhancement New feature or request label Oct 15, 2019
@jrwats jrwats self-assigned this Oct 15, 2019
@jrwats jrwats mentioned this issue Oct 15, 2019
Merged
jrwats pushed a commit that referenced this issue Oct 15, 2019
Merge pull request #91 from facebookincubator/prep4lerna
9963128 
@public
#90 Any published NPM module will now live under the packages per Lerna best practices. This is not strictly required, but makes our top-level repo slightly more sane, so we might as well abide by the community pattern.

In the process, I'm fixing the paths in yarn scripts in .*demo-apps referencing ../transform here also.

Ultimately we're doing:

transform/* => packages/*
fbt-runtime/* => packages/fbt/*
fb-tiger-hash => packages/fb-tiger-hash

Test Plan: ```
yarn
cd demo-app
yarn manifest
yarn collect-fbts
yarn translate-fbts
yarn test
yarn start
```
@jrwats
Copy link
Contributor Author

jrwats commented Oct 16, 2019

Merging into #76

@jrwats jrwats closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrwats jrwats

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrwats