{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":31927407,"defaultBranch":"main","name":"fboss","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-03-09T23:04:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1706541559.0","currentOid":""},"activityList":{"items":[{"before":"f3fde6d82fa6a553c898228c24a2daf25dcdd9dd","after":"e5b5779e0e9b6693da6d206b0c201d3b97c0b88a","ref":"refs/heads/main","pushedAt":"2024-05-30T23:47:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix operDelta sync stop error in hw ensemble\n\nSummary: D57871407 split thrift syncer shutdown to two parts in hw agent. A similar change is needed in hw ensemble also since we have few tests which perform multiswitch functionality in hw tests as well.\n\nDifferential Revision: D57993201\n\nfbshipit-source-id: 2f5eced2be00a6737b006d72dd453482225c17e4","shortMessageHtmlLink":"Fix operDelta sync stop error in hw ensemble"}},{"before":"f714f1e17b3a1126533b4b5964b544c23c86da9b","after":"f3fde6d82fa6a553c898228c24a2daf25dcdd9dd","ref":"refs/heads/main","pushedAt":"2024-05-30T23:12:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix disconnectedSubscribers counter for subs not expected to connect\n\nSummary:\nFor subscriber clientId that has 0 expected subscriptions, fix initial value\nof disconnected_subscribers counter to 0.\n\nReviewed By: peygar\n\nDifferential Revision: D57973854\n\nfbshipit-source-id: efc7dc478b1b04496300b6215274c7bbee00886c","shortMessageHtmlLink":"Fix disconnectedSubscribers counter for subs not expected to connect"}},{"before":"9117ee45eed345101fd9c471ac6d871d014522ba","after":"f714f1e17b3a1126533b4b5964b544c23c86da9b","ref":"refs/heads/main","pushedAt":"2024-05-30T21:56:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add port toggle workaround for TH5\n\nSummary: This workaround was removed in D49119095, but turns out we still need it in brcm-sai 10.2 version. Add this workaround back while continue debugging it with broadcom\n\nReviewed By: rongchunzhou\n\nDifferential Revision:\nD57972820\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: cd5877c432a7f407838e5e29216903b2dd352425","shortMessageHtmlLink":"add port toggle workaround for TH5"}},{"before":"637ca31b4393a860840116a014a056b97f9ed971","after":"9117ee45eed345101fd9c471ac6d871d014522ba","ref":"refs/heads/main","pushedAt":"2024-05-30T20:08:14.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix HW Write Behavior for Multiswitch Agent HW Test Runs\n\nSummary: To properly integrate zero SDK check with agent hw testing in multiswitch mode, I fetch the HwWriteBehavior from StateOperDelta in HwAgent and set the HW write behavior RAII object before applying initial state.\n\nReviewed By: zechengh09\n\nDifferential Revision:\nD56329330\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: efe081f70d7301506fb24e20ab34f704754e96ed","shortMessageHtmlLink":"Fix HW Write Behavior for Multiswitch Agent HW Test Runs"}},{"before":"d5e21a9f7a3753e17bf51e238501ff98416b2e0c","after":"637ca31b4393a860840116a014a056b97f9ed971","ref":"refs/heads/main","pushedAt":"2024-05-30T18:30:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"OSS target voq route scale benchmark\n\nSummary: As titled.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision: D57499375\n\nfbshipit-source-id: f60e0ddf872620d75c4b840779dec2aaa4117342","shortMessageHtmlLink":"OSS target voq route scale benchmark"}},{"before":"7019bd9605838523400a25c62fa2bb1d12a85baa","after":"d5e21a9f7a3753e17bf51e238501ff98416b2e0c","ref":"refs/heads/main","pushedAt":"2024-05-30T17:12:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Route scale benchmark for voq\n\nSummary:\nAs titled. Add benchmark to measure\n\n1. Configure remote system ports for all 144 nodes.\n2. Configure 8x512 wide ECMP routes.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision:\nD57289789\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: cb53a0839f17fbaf7a86ab7a249751741b603d17","shortMessageHtmlLink":"Route scale benchmark for voq"}},{"before":"9c0333aa081f472a5055d1baea02dfd675c8c34e","after":"7019bd9605838523400a25c62fa2bb1d12a85baa","ref":"refs/heads/main","pushedAt":"2024-05-30T17:06:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"properly update route classID when nexthop is resolved/unresolved\n\nSummary:\nCurrently, route classID is not properly updated when nexthop is resolved or unresolved. This could cause wrong classID 2 assigned even when route is resolved and trap all matching packets to cpu, see S390808.\n\nThis diff resolves this issue by 1) enhancing HwRouteTest.verifyCpuRouteChange to reproduce the wrong behavior in S390808; 2) enhancing SaiRouteManager to properly update classID when nexthop is resolved or unresolved.\n\nNote: compared with previous D57077469 (backed out later), this diff also takes route classID update from switch state into account (for queue-per-host feature use case), see \"existingManagedRouteNextHop->setMetadata()\".\n\nReviewed By: srikrishnagopu\n\nDifferential Revision:\nD57819396\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: eeda2d41dcfc6d5ffbec2f693942ca4900c13f60","shortMessageHtmlLink":"properly update route classID when nexthop is resolved/unresolved"}},{"before":"570b044f2564f0e5caadab186d4758efefb7c8a2","after":"9c0333aa081f472a5055d1baea02dfd675c8c34e","ref":"refs/heads/main","pushedAt":"2024-05-30T16:58:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Helper api to get remote switch Id\n\nSummary: As titled - used in stacked diffs\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57896402\n\nfbshipit-source-id: ef38e4804378e5d68e37f35ba1565d46cb22c84c","shortMessageHtmlLink":"Helper api to get remote switch Id"}},{"before":"e6dd9eac3bf27ef59eb6d84e14f80157126e3575","after":"570b044f2564f0e5caadab186d4758efefb7c8a2","ref":"refs/heads/main","pushedAt":"2024-05-30T16:36:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/d0f31fd547ac9edbe29b5dba3e3850aba5b102f1\nhttps://github.com/facebook/fb303/commit/c2836e2e83e98efbdd406c925a2cb19d3d8fac0f\nhttps://github.com/facebook/fbthrift/commit/0a8f857e877f62ef818a39e91bf0e6f817d41e44\nhttps://github.com/facebook/folly/commit/6a9e081bc58bf9a77376ce79c5fc7f642249afe8\nhttps://github.com/facebook/mvfst/commit/e58cc1037337c95788c71097aa23b8a3d3192415\nhttps://github.com/facebook/proxygen/commit/7e15e82fa0c43dabe7d11e0a37b68d2cda9e6372\nhttps://github.com/facebook/wangle/commit/e824a8513b21ba0474fe6358b22d518bc588c7a7\nhttps://github.com/facebookexperimental/edencommon/commit/c4658277baa7df97520c60aa505816e25a8c4556\nhttps://github.com/facebookexperimental/rust-shed/commit/d02f571cd5d5bcf127dfd6331d766abb03e3da66\nhttps://github.com/facebookincubator/fizz/commit/6a7321c406ee7bc8bc0e1d1cc42cb9f063318a0b\n\nReviewed By: namanahuja\n\nfbshipit-source-id: a9262d09ded5e3f875e18ad45be1879e4841abca","shortMessageHtmlLink":"Updating submodules"}},{"before":"8a980892cffc85529a41c62e7081e4abd537d637","after":"e6dd9eac3bf27ef59eb6d84e14f80157126e3575","ref":"refs/heads/main","pushedAt":"2024-05-30T13:31:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use withCancellation apis for agent ipc stream/sink\n\nSummary: On IPC streams/sinks, the consumer can request cancellation of further data when it exits. Using the apis with cancellation for sinks on sw agent and stream on hw agent/\n\nDifferential Revision: D57871469\n\nfbshipit-source-id: 43acf789c15ebfefad0e839befce4da9241fd992","shortMessageHtmlLink":"Use withCancellation apis for agent ipc stream/sink"}},{"before":"873f881e4d9015770fefd96d047aa4d0609b444b","after":"8a980892cffc85529a41c62e7081e4abd537d637","ref":"refs/heads/main","pushedAt":"2024-05-30T06:37:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in external/libtorrent-fbpkg/src/utp_stream.cpp +5\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nRemoving this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje, Orvid\n\nDifferential Revision: D57761241\n\nfbshipit-source-id: 633dfa0e38adb8d93aab1c15bf77de7e8244c9d5","shortMessageHtmlLink":"Remove unused-but-set variables in external/libtorrent-fbpkg/src/utp_…"}},{"before":"da2747942986a3942715bc9b98654d8ba71710bd","after":"873f881e4d9015770fefd96d047aa4d0609b444b","ref":"refs/heads/main","pushedAt":"2024-05-30T06:31:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Start pulling up multi-dsf nodes test - addTwoDsfNodesTest\n\nSummary: As titled\n\nReviewed By: zechengh09\n\nDifferential Revision: D57895250\n\nfbshipit-source-id: 48007034163633edae6d814fd15cbc7533816724","shortMessageHtmlLink":"Start pulling up multi-dsf nodes test - addTwoDsfNodesTest"}},{"before":"189ddb654f5e5f3e14f80148dd8e9f861ff5feec","after":"da2747942986a3942715bc9b98654d8ba71710bd","ref":"refs/heads/main","pushedAt":"2024-05-30T05:34:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Provide helper to schedule state update in event base thread\n\nSummary:\nAs titled. During the initial attempt of remote ECMP programming, we noticed the race condition of remote intf updates in RIB vs. route programming from BGP.\n\nImagine the following scenario\n1. DsfSubscriber receives update from another RDSW, scheduling update.\na. `stateUpdate()` will take the `pendingUpdates` lock, then\nb. it will try to update RIB within ribUpdateThread in blocking manner.\n\n2. Agent receives route programming from BGP. Route update wrapper will\na. Take ribUpdateThread to compute route updates in FIB\nb. `stateUpdate()` to take the `pendingUpdates` lock.\n\nBoth threads are trying to take lock in reverse direction, hence causing deadlock.\n\nTo mitigate this, plus to support rollback of DsfSubscriber, we decided to have Dsf updates and FIB update in the same transaction. If any update failed to applied in the hardware, we would be able to rollback both of the updates.\n\nImplementation wise, the update can be queued in ribUpdateThread, such that the lock sequence will be the same as route update (scenario 2 above).\n\nReviewed By: shri-khare\n\nDifferential Revision: D57918119\n\nfbshipit-source-id: ac1d18c57c397a052a687d2b680bb778a08de3a4","shortMessageHtmlLink":"Provide helper to schedule state update in event base thread"}},{"before":"5d49f4fe291a9d4024f1caf46d91c4289c2e1fa6","after":"189ddb654f5e5f3e14f80148dd8e9f861ff5feec","ref":"refs/heads/main","pushedAt":"2024-05-30T05:06:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Create 128 nodes for J3 as EDSW config is not ready\n\nSummary: As titled. Currently debugging some issues with 144 nodes - fallback to 128 to unblock scale testing.\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57885234\n\nfbshipit-source-id: 08f528e53b46bb517ec5bd45cb149b54f270246c","shortMessageHtmlLink":"Create 128 nodes for J3 as EDSW config is not ready"}},{"before":"a4b8b018d3a7739408a9a134dabb4f1d3895dd10","after":"5d49f4fe291a9d4024f1caf46d91c4289c2e1fa6","ref":"refs/heads/main","pushedAt":"2024-05-30T03:58:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reset Max BER if Loss of PRBS Lock Occurs\n\nSummary: All reported BERs should correspond to the continuous time interval when PRBS is running. Therefore, if PRBS loss of lock occurs, max BER should be reset.\n\nReviewed By: harshitgulati18\n\nDifferential Revision:\nD57942813\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: b7e08f1ef09c5e8a64107979c5fe4412857f4c0b","shortMessageHtmlLink":"Reset Max BER if Loss of PRBS Lock Occurs"}},{"before":"31c413694a06d70facd61c165773b7bd47fdb1f2","after":"a4b8b018d3a7739408a9a134dabb4f1d3895dd10","ref":"refs/heads/main","pushedAt":"2024-05-30T03:33:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix SetMirrorSession for TH asic\n\nSummary: Missing feature check MIRROR_PACKET_TRUNCATION for TH\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57937107\n\nfbshipit-source-id: 5dfdc78fba7e408b5b30f7373bbd9c33c3cc3f4c","shortMessageHtmlLink":"Fix SetMirrorSession for TH asic"}},{"before":"5053d83d52788351b5160b25fa21a42782398fb8","after":"31c413694a06d70facd61c165773b7bd47fdb1f2","ref":"refs/heads/main","pushedAt":"2024-05-29T23:38:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove static VDM config/data offset from code\n\nSummary: We are dynamically finding the VDM config offsets and VDM data offsets. The static offset should not be used. So I am deleting it from code so that we don't refer it accidentally\n\nReviewed By: birdsoup\n\nDifferential Revision:\nD57737041\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: 8f99a0adf1edb93737b73292ea458d853a37a3fc","shortMessageHtmlLink":"Remove static VDM config/data offset from code"}},{"before":"1cd8456d0c101807bbb948dd3b3a0a1278ddc78a","after":"5053d83d52788351b5160b25fa21a42782398fb8","ref":"refs/heads/main","pushedAt":"2024-05-29T20:42:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fboss_qsfp_test_config_sync\n\nDifferential Revision: D57927045\n\nfbshipit-source-id: cb4bbbc56e3a8242a36eab5415fe97434b01c8e4","shortMessageHtmlLink":"fboss_qsfp_test_config_sync"}},{"before":"c123b354950392ee077ccf278aa16659cbfec6af","after":"1cd8456d0c101807bbb948dd3b3a0a1278ddc78a","ref":"refs/heads/main","pushedAt":"2024-05-29T20:29:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add FBPKG config\n\nSummary:\nPytest discovers tests in a specific directory that the user configures. In our case this is through the main function with `pytest.main(..., )`. This means tests files must be installed in the correct place in order for this to work. Previously I was handling this with `setup_switch.py` which works for development, but is kind of hacky.\n\nThis adds an FBPKG config to the TARGETS file to enable building this fbpkg. Package name and ACL have already been created in other diffs.\n\nfpkg link: https://www.internalfb.com/fbpkg/package/fboss_bsp_tests?showEphemerals=true\n\nReviewed By: somasun\n\nDifferential Revision:\nD57632818\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: a2814215db392c21b0005c99de1f68cd5a3bf3a1","shortMessageHtmlLink":"Add FBPKG config"}},{"before":"00f84e51d2c70a5dc11a51b37524054a7641f5f4","after":"c123b354950392ee077ccf278aa16659cbfec6af","ref":"refs/heads/main","pushedAt":"2024-05-29T19:32:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix oss build\n\nSummary: Few more fixes for fsdb.\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57919937\n\nfbshipit-source-id: 7dbf446e4bc6743ff60642f238a1164af6ecfddb","shortMessageHtmlLink":"Fix oss build"}},{"before":"b9cdb0d2acdc7bf3508fa495f32ff3c73fbd8239","after":"00f84e51d2c70a5dc11a51b37524054a7641f5f4","ref":"refs/heads/main","pushedAt":"2024-05-29T17:00:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Port copp qos tests to agent hw tests\n\nSummary: There are two more copp tests which need migration. these tests didn't show up on my audit check last time since they have a different signature. These tests fail on sai and bcm hw tests and are marked known bad so that we can retire the hwtests. Porting them to agent test and marking them known bad\n\nReviewed By: daiwei1983\n\nDifferential Revision: D56259780\n\nfbshipit-source-id: 93c5c086bc7f368b7813256d1e52417a85ecdbd4","shortMessageHtmlLink":"Port copp qos tests to agent hw tests"}},{"before":"4c35fcf1db150878a3efaddf9b7ba2f78ddd40d1","after":"b9cdb0d2acdc7bf3508fa495f32ff3c73fbd8239","ref":"refs/heads/main","pushedAt":"2024-05-29T16:39:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/3c0bc88928830c9cbc89bd64549b92b036ba0839\nhttps://github.com/facebook/fb303/commit/fb88430a5a0ede52c7e1737a2689950963f66960\nhttps://github.com/facebook/fbthrift/commit/1e3bf4cff9f1d8b682f8a2cf57deb91533c5e063\nhttps://github.com/facebook/folly/commit/1d92f4017ecc80626628547f597f352a5bcf870e\nhttps://github.com/facebook/mvfst/commit/9a3a8a33cb859ceebcac5eb3ef3dca9ecf9d1c4b\nhttps://github.com/facebook/proxygen/commit/dc2522de3b536605b01a4dd16d3e1648e3823f79\nhttps://github.com/facebook/wangle/commit/5748ee81890496ea716a3ce41e1122336d27dadb\nhttps://github.com/facebookexperimental/edencommon/commit/c1db1da557360d50b402ff2c66d6e1c54a9ebed1\nhttps://github.com/facebookexperimental/rust-shed/commit/56ebaa636edd032be85ae7c2f530e78919c2290e\nhttps://github.com/facebookincubator/fizz/commit/8a72c44be10d22558b3bd16604d42c364ba1527a\n\nReviewed By: namanahuja\n\nfbshipit-source-id: 9a9da5e78e4337564b1887ef1db0be1a8b63791b","shortMessageHtmlLink":"Updating submodules"}},{"before":"8b24114e682169da07174139af38a034143abd10","after":"4c35fcf1db150878a3efaddf9b7ba2f78ddd40d1","ref":"refs/heads/main","pushedAt":"2024-05-29T16:07:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"hw agent handling to exit sink event wait loop\n\nSummary:\nOn stress testing with repeated warmboots, hw agent can get stuck trying to shut the ipc sink streams to sw agent. The sink event generator waits on a queue for next event and enqueues the event to the sink. Normally when sw agent exits, the sink event generator gets an thrift connection failed exception and exits the loop. In failing cases, the exception is not observed and the thread waits for the next event and eventually hits SIGABRT.\n\nFix: Enqueue a dummy event so that the wait loop can be exited\n\nAnother option tried was to use cancellation for the dequeue call. The hw agent is able to exit in this case but if sw agent alone restarts, then event waiting code is cancelled and do not get an exception which allows it to retry connection to sw agent\n\nDifferential Revision: D57868686\n\nfbshipit-source-id: 418df61a6512327b89568c4a1788a58a6372da9b","shortMessageHtmlLink":"hw agent handling to exit sink event wait loop"}},{"before":"72597e500505b36e4b9b9a6b2d6c6e4280d4b836","after":"8b24114e682169da07174139af38a034143abd10","ref":"refs/heads/main","pushedAt":"2024-05-29T15:25:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reduce delay in Cdb command write\n\nSummary: We have a default delay of 100ms between cdb commands which is unnecessary as we poll for cdb command success anyways. Reduced the delay from 100ms to 10ms instead to speed up fw upgrade\n\nReviewed By: rajank7\n\nDifferential Revision: D57894588\n\nfbshipit-source-id: b88abf3f0dc51255f895f009f4ac9ff33f80775b","shortMessageHtmlLink":"Reduce delay in Cdb command write"}},{"before":"76b1aba21a9592aeb2342d3ee17805e154dfc227","after":"72597e500505b36e4b9b9a6b2d6c6e4280d4b836","ref":"refs/heads/main","pushedAt":"2024-05-29T15:13:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove check for HwAsic::Feature::SCHEDULER_PPS in Agent test\n\nSummary:\nAfter landing D57828232, we should be able to remove this check as these tests will\nno longer be run for TAJO.\n\nReviewed By: srikrishnagopu, msomasundaran\n\nDifferential Revision: D57828272\n\nfbshipit-source-id: fda751451625ac42c572a622471cdaf823abe378","shortMessageHtmlLink":"Remove check for HwAsic::Feature::SCHEDULER_PPS in Agent test"}},{"before":"fd96f0d1c12a6269a4af406c5ac81d17b39b344d","after":"76b1aba21a9592aeb2342d3ee17805e154dfc227","ref":"refs/heads/main","pushedAt":"2024-05-29T05:30:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Generate replay data for i2clog from log file\n\nSummary: This diff will help us both when writing the replayer (thread re-doing the same steps for read/write) and also with testing the logging to a file (is done correctly)\n\nReviewed By: birdsoup\n\nDifferential Revision: D57056556\n\nfbshipit-source-id: 428b27e2482b5eb42ed94c72fc686bbc8ddcf673","shortMessageHtmlLink":"Generate replay data for i2clog from log file"}},{"before":"b5e9af976312364fa0b07c1b9962b9df6e1dbe64","after":"fd96f0d1c12a6269a4af406c5ac81d17b39b344d","ref":"refs/heads/main","pushedAt":"2024-05-29T03:06:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pull up dram enqueue, dequeue tests\n\nSummary: As titled\n\nReviewed By: nivinl\n\nDifferential Revision: D57873610\n\nfbshipit-source-id: b41d51d5b4e8f97924dc1fdc45fb57424f6d9d4f","shortMessageHtmlLink":"Pull up dram enqueue, dequeue tests"}},{"before":"2f57fc9bc7a280bc94a5fb666e94498d0bd431ee","after":"b5e9af976312364fa0b07c1b9962b9df6e1dbe64","ref":"refs/heads/main","pushedAt":"2024-05-29T01:24:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Hw test to reproduce S410132\n\nSummary:\nBelow is the original crash observed in production after warmboot.\n{P1365048152}\n\nThe sequence of API calls which caused the crash is {P1363828811}\n\nThe previous 3 diffs in this stack includes the BRCM patches. New test added here will reproduce the crash in the 4th iteration in an n warmboot test.\n\nDifferential Revision: D57408877\n\nfbshipit-source-id: 6a3ad4ae450d0889db7919488464c678c7cece02","shortMessageHtmlLink":"Hw test to reproduce S410132"}},{"before":"229494d766a017d8afc9f9f36fa2a9e67f8e9791","after":"2f57fc9bc7a280bc94a5fb666e94498d0bd431ee","ref":"refs/heads/main","pushedAt":"2024-05-29T01:11:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Tune down sub/unsub logging\n\nSummary: move to DBG1 to avoid spamming clients\n\nReviewed By: peygar\n\nDifferential Revision: D57889745\n\nfbshipit-source-id: c83a0e3be235d62731d116a5695b5d73bfb04c04","shortMessageHtmlLink":"Tune down sub/unsub logging"}},{"before":"97912f7e70f0784005774c8d45384e25c8ea8678","after":"229494d766a017d8afc9f9f36fa2a9e67f8e9791","ref":"refs/heads/main","pushedAt":"2024-05-29T00:25:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"few oss build fixes\n\nSummary: oss build has been broken because of our thrift dep. A few of our changes went through and broke our build too. Fixing ones we know of for now, but since build is broken not sure if there are others\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57865349\n\nfbshipit-source-id: 3e08f69ca41bab73b60f9f38b12b0b00413d7262","shortMessageHtmlLink":"few oss build fixes"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWIJWpgA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fboss"}