-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keys() needs to set skip to false after iteration. #5
Comments
Sorry for being late, I really haven't paid attention to this reminder for a long time. Thanks for pointing out the issue and giving a fix PR. |
I added the tag for v1.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using the README example with a small change (add optional "foo") will result in the
Without()
being ignored. This is because AnySchema.Optional() calls ctx.Skip():This results in no errors, even though we should expect "panic: field
window
contains title"If you remove the "foo" line, it works correctly:
The problem is in the
ObjectSchema.Keys()
- it needs to set ctx.skip to false after the for loop.The text was updated successfully, but these errors were encountered: