-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSIO production API urls hardcoded in the code #357
Comments
The approach would be to move the env vars out of the reusable pipeline just as we've done on a similar function https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/deployKubernetesSnapshot.groovy#L99-L108 they are instead passed as a |
Is there a way to figure out which Jenkinsfiles use these values? I.e. what breaks if we remove it from library and where they need to be placed? |
At the moment there's only two repos that deploy snapshot builds so updating them should do it: |
There are API urls hardcoded in this repository:
https://github.com/fabric8io/fabric8-pipeline-library/blob/master/vars/deployOpenShiftSnapshot.groovy#L57-L61
@jstrachan mentioned this file is not really used when someone uses fabric8-pipeline-library, which is good.
It would be great if you could use more descriptive name for the file mentioned above - something like
deployOSIOProdSnapshot.yaml
maybe?And/or (when there is time) take the hardcoded values out to some config, in case the groovy script has a potential to be used for other deployments or by other people.
The text was updated successfully, but these errors were encountered: