Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar rename is dangerous #403

Open
QmwJlHuSg9pa opened this issue Aug 29, 2023 · 0 comments
Open

Sidebar rename is dangerous #403

QmwJlHuSg9pa opened this issue Aug 29, 2023 · 0 comments

Comments

@QmwJlHuSg9pa
Copy link

QmwJlHuSg9pa commented Aug 29, 2023

Hi, just installed Marker via Flathub to give it a try. Mind you, the version there (2020.04.04) is outdated.

Sidebar renaming is broken and destructive; it can have adverse consequences (file loss).

Here's what happened:

  1. I misclicked and opened an ODS (spreadsheet) file by mistake. Curiously, the output in Marker was void -- I kind of at least expected a "not Markdown content" warning, or even just a garbled interpretation of the file's bytes. The ODS file itself was untouched, at least.
  2. Whatever, lets open an actual Markdown file.
  3. Now, Lets try renaming the Markdown file in sidebar (My thinking: does this actually rename the file within the filesystem, or just within a hypothetical, abstracted database representation)? OK, it renames the actual file.
  4. Then, I tried to double click on the ODS file in sidebar, out of curiosity. This is where things went wrong. Marker erroneously renamed the file without my input, to the new name of the aforementioned markdown file! I.e. myodsfile.ods -> newmarkdownname.md
  5. This not being bad enough, the renamed ODS file was now 0 bytes in my filesystem! Despite not pressing "Save", nor modifying the file contents within Marker's interface.

Notes:

  • Number 4. applies to any file, even other Markdown files.
  • Number 5. seems to apply to any file that is not considered compatible with Marker.
  • In either case: if both files are within the same directory, the "old" named file may completely cease existing, leaving one with just a single file!

I don't know how things behave in 2023, but file renaming really should require a confirmation dialogue, and it shouldn't be so easy to overwrite (or delete) another file within the same directory!

I can not recommend this program (at least the Flathub distribution) to anyone! No, I spent a day trying to recover my lost file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant