Django dark mode is not working

[tbhaxor]

Python version
3.9

Django version
3.2.5

Package version
0.16.3

Current behavior (bug description)
Django default admin dark mode not working with django-admin-interface.

Expected behavior
I want to use the flat design provided by django-admin-interface but with dark mode

[fabiocaccamo]

@tbhaxor me too :), but this would require a lot of work and at the moment I have not the time for working on it.

[tbhaxor]

Maybe i can help you. will check in upcoming weekend

[fabiocaccamo]

• Many color fields must be added to give the possibility to customize all colors
• Every color field should must become 2 color fields, 1 for light theme and another for the dark one

[tbhaxor]

@fabiocaccamo Could you guide me on setting up development environment

[fabiocaccamo]

@tbhaxor just create a django project locally (you can follow the official django tutorial) and install the package without pip to be able to modify it. For testing check here.

[merwok]

I wonder if duplicating all the colour fields is the way to go here.

Would all the dark fields be required? Could be bothersome for a project that doesn’t need/want a dark mode. But if they are optional, then there could be fields left out by mistake, making an incomplete or unreadable theme.

What if Theme had a boolean field to indicate if it’s light or dark, and a one-to-one relation to theme table to indicate the “twin” theme to use according to browser mode?

[tbhaxor]

We can have a switch or some selector giving users to create two themes one for dark and another for light

[fabiocaccamo]

@merwok it is surely a smart solution, maybe a little bit overcomplicated.

I'm guessing if in this case there is really the need to have an automatic switch between light and dark themes, in my opinion there is not, I don't care very much about the trends.

I would start by adding the fields to customise all the theme colors, in this way it will be possible to have also dark themes (including some predefined ones).

[saymoncoppi]

If you need help to do that pls let me know. Maybe I could help :)

[fabiocaccamo]

@saymoncoppi if you want to work on this you could start from here:

I would start by adding the fields to customise all the theme colors, in this way it will be possible to have also dark themes (including some predefined ones).

[notnotrachit]

Suggestion: Just add another color selector for background. Thats it

[san425]

hey is this in any coming update or is it available right now? I'm not really looking for a dark mode, just the ability to choose my own background color. thanks :)

[merwok]

This is an open ticket, with no pull request linked.

[VaZark]

What do you think of adding two active themes ? One can be used for the light mode and the other can be used for dark mode.

Django officially support browser preference, so we can use that var as a param to get_active_theme. Not sure how it is used but shouldn't be too hard to find

[fabiocaccamo]

@VaZark let's start by splitting the problem into smaller problems:

• For supporting a completely custom dark theme, we must be able to customise all theme colors before, I don't think that changing only the background color is enough.

• For managing the theme switching, I would allow users to flag two active themes, one for light and another one for dark theme.
  This can be easily achieved by adding an active_dark BooleanField without overcomplicating the database structure.

• If users select only a light theme or only a dark theme, that theme will be always used.
  Alternatively if both themes (light and dark) have a selected theme, the theme that matches the user preferences will be used.

[Macktireh]

Hi,
As dark mode is becoming more of a standard feature, do you plan on adding support for dark mode, especially considering that Django already supports it?

[fabiocaccamo]

Hi @Macktireh
this issue is open because it's my intention to add dark mode support.

Generally I work on enhancements / features when I have enough free time or I need them on paid projects I'm working on.

If you really need this feature as soon as possible for a commercial project consider contributing to this open source project by submitting a pull-request, alternatively ask your boss to sponsor this project via GitHub sponsors.

[rob32]

@fabiocaccamo
What do you think of the idea of removing the button altogether? This could be quickly reversed later if necessary.

[fabiocaccamo]

@rob32 will be hidden in the next release.

[fabiocaccamo]

@rob32 it's hidden in 0.28.0 version.

[dysphael]

up