Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Colours #118

Open
DreepyYunky opened this issue Jan 5, 2024 · 4 comments
Open

Custom Colours #118

DreepyYunky opened this issue Jan 5, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@DreepyYunky
Copy link

Before I got this plugin, I used VS Code and GitLens. GitLens comes with a similar feature to this plugin, but it's grey, not green.

There's more to it though. Some themes have their comments themed (Including mine, I'm using a theme similar to VS Code default) and this might cause confusion for these people as the blame is similar to the comments. This is demonstrated by a screenshot I took.

What's the comment and what's the blame?

HOW CAN THIS BE FIXED?

Well here's my syntax that will allow the user to set the colour of the blame (This code assumes you're using lazy.nvim).

return {
   "f-person/git-blame.nvim",
   opts = {
      colour = "grey" -- Can be renamed to "color", I have no problem with that.
   },
}
@bossley9
Copy link
Collaborator

Hello, thanks for the suggestion! I think that's a good idea, we will look into implementing this 👍

@bossley9 bossley9 added the enhancement New feature or request label Jan 17, 2024
@f-person
Copy link
Owner

Hi, @DreepyYunky! Is setting a custom highlight group and customizing its colors sufficient for your use case? https://github.com/f-person/git-blame.nvim?tab=readme-ov-file#highlight-group

@DreepyYunky
Copy link
Author

Wow I haven't checked on this issue in a while, @f-person I'll try the highlighting groups and see if it'll work.

@DreepyYunky
Copy link
Author

On the highlighting groups, it is cool, but maybe can still be confused. Custom Colouring will allow users to set distinct colours. I might work on this and open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants