Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose logging options like human readable verbose and json format in values.yaml #3440

Closed
rojomisin opened this issue May 1, 2024 · 3 comments · Fixed by #3558
Closed
Labels
good first issue Good for newcomers helm kind/feature Categorizes issue or PR as related to a new feature.

Comments

@rojomisin
Copy link

Is your feature request related to a problem? Please describe.
It would be very helpful to make the logs more readable and operator friendly to expose simple yaml options in the helm chart. Cert-manager does this like:

## -- Map of extra arguments to pass to container.
extraArgs:
  zap-time-encoding: iso8601
  loglevel: debug

and it's documented on their site

Describe the solution you'd like
helm show values external-secrets/external-secrets should show a default values.yaml file which shows the currently logging settings and commented out reference docs on how to enable json, human readable, and verbosity level settings

Describe alternatives you've considered
n/a

Additional context
n/a

@rojomisin rojomisin added the kind/feature Categorizes issue or PR as related to a new feature. label May 1, 2024
@gusfcarvalho gusfcarvalho added good first issue Good for newcomers helm labels May 1, 2024
@KyriosGN0
Copy link
Contributor

Hi, i would like to work on this

@Skarlso
Copy link
Contributor

Skarlso commented Jun 7, 2024

Feel free to pick it up! :) Good luck!

@KyriosGN0
Copy link
Contributor

Hi, PR opened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers helm kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants