-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SecureString
for PushString
to AWS Parameter Store
#3422
Closed
Labels
good first issue
Good for newcomers
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
To whoever pick up this issue - this change should be done on |
For |
Can I work on this improvement? |
Sure. Go ahead! |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
kind/feature
Categorizes issue or PR as related to a new feature.
Is your feature request related to a problem? Please describe.
I'm baffled as to why this is not a customizable flag in the
PushSecret.spec
to set the parameter type for AWS SSM Parameter Store.This is the offending line:
external-secrets/pkg/provider/aws/parameterstore/parameterstore.go
Line 141 in e32bc39
This should obviously be something the client should be able to customize, with the default of
String
if you really want it. But, nevertheless, it shouldn't be a hard-coded value.Describe the solution you'd like
I'd like to be able to modify the value to
SecureString
please. On the same topic, you should also be able to set the Parameter Tier of eitherStandard
orAdvanced
. referenceDescribe alternatives you've considered
The alternative is to fork the repo and modify it to have the default hard-coded value of
SecureString
(cause I'm not a Go guy by any means 😬).Additional context
nada
The text was updated successfully, but these errors were encountered: