-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the res.write interception into a separate repo #13
Comments
Love this move. |
So just if you were wondering, @aredridel , the idea is to provide a through stream-like interface as well as a buffered-up interface, not only for use in this library, but for use to do things like re-write links in HTML responses. It would also take care of altering the headers like |
That sounds like my use cases! Security hacks, link rewrites, compression, verification trailers, all kinds of uses. |
All very important uses indeed. The main reason this alters a |
Can't happen soon enough. Another use case: output validation. Any sort of tentative timeline? |
Just time-dependent. It's also not easy to get right; there are so many edge cases. I also need it very much :) |
Any updates on this? I need this for a bandwidth monitoring middleware I'm working on. For now, I resorted to copy-pasting the code from here :/ |
I've started working on something for my own middleware: expressjs/express#2811 (comment) Would be nice to see if it works with this module. Eventually we could extract the import responseUse from 'response-use';
app.use(responseUse);
app.use(compression); The compression module could add itself to the list of transform stream with Let me know your thoughts. |
Created a repo here: https://github.com/olalonde/express-transform |
It needs to be in it's own repo so it can be well-tested and not need tests polluting this library.
The text was updated successfully, but these errors were encountered: