Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 update causing issues with other software #13669

Open
Josh-XT opened this issue Oct 18, 2024 · 5 comments
Open

Numpy 2.0 update causing issues with other software #13669

Josh-XT opened this issue Oct 18, 2024 · 5 comments

Comments

@Josh-XT
Copy link

Josh-XT commented Oct 18, 2024

Forcing numpy to 2.0+ forces breaking changes on other software. Unless it is absolutely required to use 2.0+, can this be reverted?

184e508

@rphellan
Copy link

rphellan commented Oct 19, 2024

Yes, also numpy 2.0.0 requires python 3.9. Then, the line numpy>=2.0.0; python_version < "3.9" leads to a bug.

@Darshan2104
Copy link

Darshan2104 commented Oct 24, 2024

Yes it is creating issue. I am facing issue while working with keyphrase-vectorizers==0.0.10 where it is using spacy version >=3.0.0 and it is installing spacy==3.8.2 i'm using python3.8 with numpy==1.24.3 which is compatable but spacy3.8.2 is looking for numpy2.0+ and that is not compatable with python3.8.

@lsmith77
Copy link

adding fasttext to the list of libs not compatible (and unfortunately also not maintained). we have found it to be the best language detection for shorter text.

@simon-ging
Copy link

@lsmith77 off-topic but I uploaded a numpy2 version of fasttext, because I ran into the same problem, and it was just a one line fix. see https://pypi.org/project/fasttext-numpy2/

@honnibal
Copy link
Member

There's no way to support both numpy v1 and numpy v2 in the same release. You'll need to pin your spaCy dependency to have an upper-bound that uses numpy v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants