Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync atbash-cipher #839

Open
4 tasks done
Tracked by #628
mk-mxp opened this issue Nov 6, 2024 · 3 comments · May be fixed by #847
Open
4 tasks done
Tracked by #628

Sync atbash-cipher #839

mk-mxp opened this issue Nov 6, 2024 · 3 comments · May be fixed by #847
Assignees
@tomasnorre

Comments

@mk-mxp
Copy link
Contributor

mk-mxp commented Nov 6, 2024 •
edited by tomasnorre
Loading

  • Run bin/configlet sync -u -e atbash-cipher --yes --docs --filepaths --metadata --tests include (updates the Markdown files and maybe tests.toml)
    • docs: instructions unsynced: atbash-cipher
  • Drop strict types comments from test file and example code (these are useless)
  • Add and sync test meta data to tests (uuid / @testdox in DocBlocks)
  • Decide on adding / adjusting / ordering test cases to match current problem specs

Do not redesign the student's interface or add test cases that would invalidate existing community solutions. These are extra tasks, which should be discussed in advance.
@mk-mxp mk-mxp mentioned this issue Nov 6, 2024
Open
85 tasks
@tomasnorre tomasnorre self-assigned this Nov 7, 2024
@tomasnorre
Copy link
Contributor

the decode() is currently not implemented in example.php so the missing test cases (all for decode()) is logically failing.

Should decode() be added to the example.php or left out from the tests?

@tomasnorre tomasnorre linked a pull request Nov 7, 2024 that will close this issue
Open
@mk-mxp
Copy link
Contributor Author

mk-mxp commented Nov 9, 2024

There currently is a change to the instructions and possibly a change to the tests going on. So maybe we should wait with this one.

About adding decode: Yes, I think that is worth breaking all existing solutions. @homersimpsons Do you agree?

@homersimpsons
Copy link
Contributor

About adding decode: Yes, I think that is worth breaking all existing solutions. @homersimpsons Do you agree?

There are 128 published solutions. So yes let's add decode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasnorre tomasnorre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sync atbash-cipher tomasnorre/exercism-php
3 participants
@tomasnorre @homersimpsons @mk-mxp